Added 'adopt-hotspot' and 'adopt-openj9' #155
Conversation
There was a problem hiding this comment.
@MarcelCoding Thank you for submitting this great PR!
I have left a few comments. Please take a look.
|
@maxim-lobanov thanks for your feedback. I hope I changed it as you expected. |
|
@MarcelCoding , Yes! It is what I expected. I have left minor nitpick with variable naming. |
|
I did it in camel case. |
Camel case is definitely more preferable :) @konradpabjan could you please review this PR too? |
|
Sorry, I did it now. |
There was a problem hiding this comment.
Looks great! Thanks for the contribution ❤️
As pointed out earlier in some comments by @maxim-lobanov, the test matrix is getting a little bit large but that's up to us to sort out. If we add more distributions then we could easily have 150+ or 200 builds per PR and that's getting into overkill territory that can start to cause delays for other PRs. We need some way better way to control which tests kick off per type of PR
|
Before adding additional distro names like this incrementally and/or choosing their names on an ad-hoc basis, it would be useful to examine the full set of names expected for the distribution property, thinking a few months and steps ahead. The names chosen will potentially end up being “set in stone”, so thinking of what happens to them e.g. 1 or 2 years down the road is important. Other (currently available) distributions and possible names to be added include e.g. corretto, liberica, sapmachine, oracle-openjdk. We should also consider the much anticipated appearance of Eclipse Adoptium related distributions, and the likelihood of multiple distributions being referred to from Eclipse Adoptium, using the Eclipse Adoptium build or quality mechanisms and/or infrastructure. One (but not the only one) of those Adoptium related distributions will be Eclipse Temurin which will likely, over time, replace the current adopt-hotspot name proposed here, but will probably be properly named and referred to as “temurin” or “eclipse-temurin” rather than “adopt” or “adopt-hotspot”. Additional distributions are expected there, including e.g. the newly announced Microsoft build of OpenJDK. (So “microsoft”? “microsoft- |
There was a problem hiding this comment.
Just a nit (thanks @dmitry-shibanov for pointing me here).
Otherwise you can also add fixes: #160 to the PR message now :)
|
@MarcelCoding I have left one more comment. We need small trick for HotSpot to make sure that pre-cached versions will be consumed on Hosted runners. |
|
@maxim-lobanov Ok, I fixe it. |
|
and @bmarwell |
|
I don't did a force push, that you can see the changes better. I think you can squash this pr at the end. I added also some tests for the toolchain folder for adopt. |
|
@MarcelCoding validated and it works as expected with cache. |
|
Hi all - Martijn from AdoptOpenJDK here. With the shift to Eclipse Adoptium we won't be providing OpenJ9 based builds going forward (that'll come directly from IBM). I don't want to speak directly for IBM here, but if we could pause on that a few days so that they can chime in? CC @tellison |
|
Hello @karianna , Yes, I think it is not a problem to wait a few days |
I do not think this will happen. In that case IBM would have informed me on my business mail. They know that we are using the adoptopenjdk.net API. Are you sure this hasn’t been forgotten to communicate to customers? |
|
@karianna isn't Openj9 in the eclipse foundation? |
|
Hi Marcel,
Yes, Eclipse OpenJ9 is in the Eclipse Foundation, but the Foundation does
not actually build the binaries itself, only AdoptOpenJDK and IBM ever did
as vendors.
Cheers,
Martijn
…On Sun, 11 Apr 2021 at 11:42, Marcel ***@***.***> wrote:
@karianna <https://github.com/karianna> isn't Openj9 in the eclipse
foundation?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#155 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABME2FGMV3JUYGKLFMPCV3TIF4LDANCNFSM42M5U4NQ>
.
|
|
Hi Benjamin,
My apologies I definitely didn't want to cause any concern here! The
existing Adopt API is definitely *not* going away (if ever) far too many
folks rely on it.
At some stage, the next iteration of Hotspot-based binaries will be served
through the upcoming api.adoptium.net (being worked on as part of the
Adoptium Marketplace concept) and we'll be asking folks to migrate over if
they want to access those newer binaries.
We'll get some clarity on the OpenJ9 story soon, but again to reassure
you, we're *not* switching off the existing API.
…----
Right after having written all of this, I think this PR should just go
ahead as it accurately represents what's happening today. A subsequent PR
can always go in later to model whatever happens in the future.
Cheers,
Martijn
On Sun, 11 Apr 2021 at 11:42, Benjamin Marwell ***@***.***> wrote:
Hi all - Martijn from AdoptOpenJDK here. With the shift to Eclipse
Adoptium we won't be providing OpenJ9 based builds going forward (that'll
come directly from IBM). I don't want to speak directly for IBM here, but
if we could pause on that a few days so that they can chime in? CC
@tellison <https://github.com/tellison>
I do not think this will happen. In that case IBM would have informed me
on my business mail. They know that we are using the adoptopenjdk.net
API. Are you sure this hasn’t been forgotten to communicate to customers?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#155 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABME2EGEA6F4RYJYFSJ6IDTIF4KPANCNFSM42M5U4NQ>
.
|
|
Here's some recent info about access to Eclipse OpenJ9 based JDKs : https://developer.ibm.com/blogs/ibm-joins-eclipse-adoptium-and-offers-free-certified-jdks-with-eclipse-openj9/ I'm afraid there's not much detail in there to help progress the OpenJ9 part of this PR. As far as I know, though, nothing is changing for the April update release coming very soon at AdoptOpenJDK. We'll be providing more details in advance of the release process migrating fully to Eclipse Adoptium. Stay tuned (but don't hold your breath :) )! |
|
Thanks for the info @karianna @mstoodle Given that the existing APIs are not being switched over yet (it will probably take some time), I'm inclined to merge these changes in now. Any objections? The OpenJ9 story is a bit ambiguous at the moment but I don't consider that to be a blocker. If we do need to make changes in the future then I'm sure we'll know well in advance and we'll have plenty of time to react. |
|
Any plans merging this and releasing a v3 @maxim-lobanov? |
|
Merged PR and released version |
|
After updating the action version to |
|
Updated |
Description:
Added the ability to select the implementation of the adoptopenjdk distributions.
Related issue:
#13 (comment)
Check list: