Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'adopt' is ambigous #160

Closed
4 of 5 tasks
bmarwell opened this issue Apr 9, 2021 · 3 comments
Closed
4 of 5 tasks

'adopt' is ambigous #160

bmarwell opened this issue Apr 9, 2021 · 3 comments
Labels
bug Something isn't working

Comments

@bmarwell
Copy link

bmarwell commented Apr 9, 2021

Description:

Distribution name 'adopt' is ambigous.
There are two VM implementations available under this name, Hotspot and OpenJ9.

Task version:

v2

Platform:

  • Ubuntu
  • macOS
  • Windows

Runner type:

  • Hosted
  • Self-hosted

Repro steps:

distribution: adopt

Expected behavior:

Expected adopt-hotspot and adopt-openj9 instead.

Actual behavior:

One of them is chosen, I do not know which one – probably hotspot?

@dmitry-shibanov
Copy link
Contributor

Hello @bmarwell. Currently the action supports only hotspot releases and "adopt" references hotspot binaries. We have an active pull request to add support for openj9 implementation.

@maxim-lobanov
Copy link
Contributor

Merged PR and released version v2.1.0 Link. No need to bump major version since there are no breaking changes.
Going to update v2 tag to point to v2.1.0 tomorrow. Will be appreciate for any testing and confirmation that it works as expected.

@dmitry-shibanov
Copy link
Contributor

Hello @bmarwell, pull request was merged and v2 tag was also updated. I'm closing the issue. If you have any concerns feel free to reopen the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants