Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem matchers: Don't require relative paths to start with ./ or ../ #98

Merged
merged 1 commit into from Dec 17, 2021

Commits on Jan 16, 2021

  1. Don't require relative paths to start with ./ or ../

    Errors reported by Go, even when containing relative paths, do not
    always begin with ./ or ../ – for example:
    
    	$ go build ./...
    	# honnef.co/go/tools/lintcmd
    	lintcmd/format.go:28:8: syntax error: cannot use path := filepath.Clean(pos.Filename) as value
    
    We could require either ./, ../ or at least one path separator and
    still match Go's output. However, commonly used linters (such as
    Staticcheck and golint) never use ./ for relative paths. Their output
    stopped being matched when we moved from v1 to v2. I believe that
    being able to match the output of linters is worth relaxing the
    pattern for.
    
    This change slightly relaxes the stricter pattern that was introduced
    as part of v2 to address actions#46. However, the pattern is still stricter
    than it was in v1 and as strict as it can be for most users.
    dominikh committed Jan 16, 2021
    Copy the full SHA
    ec55db5 View commit details
    Browse the repository at this point in the history