Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(): cache resolve version input #267

Merged
merged 1 commit into from Oct 17, 2022
Merged

fix(): cache resolve version input #267

merged 1 commit into from Oct 17, 2022

Conversation

n33pm
Copy link
Contributor

@n33pm n33pm commented Sep 12, 2022 •
edited

Description:
pass resolved go version to cache.
Problem if only go-version-file is set.

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

@n33pm n33pm requested a review from a team September 12, 2022 13:47
@e-korolevskii
Copy link
Contributor

Hello @n33pm

Could you please solve the conflicts?

@n33pm n33pm force-pushed the fix/cacheVersionInput branch 2 times, most recently from 618bbe2 to 27d2bcb Compare October 17, 2022 12:36
@n33pm n33pm requested review from marko-zivic-93 and dmitry-shibanov and removed request for marko-zivic-93 and dmitry-shibanov October 17, 2022 12:37
@dmitry-shibanov
Copy link
Contributor

Hello @n33pm. Could you please sync with the main upstream and run git merge main or git rebase main commands to sync with current changes. After that could you please run npm ci && npm run build.

@n33pm n33pm requested review from dmitry-shibanov and removed request for marko-zivic-93 October 17, 2022 15:10
@dmitry-shibanov dmitry-shibanov merged commit c4a742c into actions:main Oct 17, 2022
@n33pm n33pm deleted the fix/cacheVersionInput branch October 31, 2022 15:04
adilhusain-s pushed a commit to adilhusain-s/setup-go that referenced this pull request Feb 6, 2023
@n33pm @adilhusain-s
fix(): cache resolve version input (actions#267)
fe778e1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitry-shibanov dmitry-shibanov dmitry-shibanov approved these changes

@Muniz-colima Muniz-colima Muniz-colima approved these changes

@marko-zivic-93 marko-zivic-93 marko-zivic-93 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@n33pm @e-korolevskii @dmitry-shibanov @Muniz-colima @marko-zivic-93