Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract archive fix #242

Closed
wants to merge 16 commits into from
Closed

Conversation

redanthrax
Copy link

Description:
Updated tool cache and fixed extract issue on windows.

Related issue:
Fixes #241

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

@redanthrax redanthrax requested a review from a team June 28, 2022 21:08
@dmitry-shibanov
Copy link
Contributor

Hello @redanthrax. Thank you for your pull request. Could you please run the npm run format command and use licensed tool to regenerate licenses.

@dmitry-shibanov
Copy link
Contributor

Hello @redanthrax. Could you please confirm that self-hosted runner works as expected with your changes ?

@redanthrax
Copy link
Author

Hello @dmitry-shibanov. Yes after the changes the self hosted runner works as expected. Basically Extract-Archive expects a .zip file extension so when using the filename instead of the randomly generated filename in Windows it works as expected.

@panticmilos
Copy link
Contributor

Hi @redanthrax, can you resolve conflicts with the main branch?

@redanthrax
Copy link
Author

@panticmilos I have resolved the conflicts.

@dmitry-shibanov
Copy link
Contributor

Hello @redanthrax. You have conflict lines in package-lock.json. Could you please fix them?
image

@panticmilos
Copy link
Contributor

Hi @redanthrax,

Could you run npm run pre-checkin again and push? One check for the dist folder is failing

@panticmilos
Copy link
Contributor

Hi @redanthrax, since checks are still failing let's try the following steps. I believe you already have done them, but this check error is weird for me.

  1. Checkout to main and pull the latest changes, git pull
  2. Return to your branch and git rebase main
  3. Resolve conflicts if any, if multiple commits are there then run git rebase --continue
  4. After that run npm run pre-checkin
  5. Test your changes again, and git push

If there are no changes after step 4 to push let me know and thank you.

@panticmilos
Copy link
Contributor

@redanthrax, still has conflicts with main branch :(

@panticmilos
Copy link
Contributor

@redanthrax, just a gentle ping ☎️

@redanthrax
Copy link
Author

Closed in favor of #250

@redanthrax redanthrax closed this Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants