Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement "check-latest" flag to check if pre-cached version is latest one #186

Merged
merged 4 commits into from Feb 9, 2022
Merged

Implement "check-latest" flag to check if pre-cached version is latest one #186

merged 4 commits into from Feb 9, 2022

Conversation

dmitry-shibanov
Copy link
Contributor

Description:
In scope of this pull request we add support for check-latest input. If check-latest is set to true, the action first checks if the cached version is the latest one in go-versions repository. If the locally cached version is not the most up-to-date, a Go version will then be downloaded.
Additional changes:

  • The setup-node@v1 action's tag was changed to setup-node@v2 in check-dist.yml
  • Updated licensed tool in the licensed.yml.
  • The npm install command was changed to npm ci in the workflow.yml.
  • Updated actions/core to the latest version.

Related issue: #73

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

@dmitry-shibanov dmitry-shibanov requested a review from a team February 2, 2022 11:45
action.yml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
src/installer.ts Outdated Show resolved Hide resolved
src/main.ts Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
- name: npm install
run: npm install
- name: npm ci
run: npm ci
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
src/installer.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@brcrista brcrista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed a few more small things, but otherwise 🚢

@dmitry-shibanov dmitry-shibanov merged commit bfdd357 into actions:main Feb 9, 2022
panticmilos pushed a commit to panticmilos/setup-go that referenced this pull request Aug 4, 2022
n33pm pushed a commit to n33pm/setup-go that referenced this pull request Oct 17, 2022
adilhusain-s pushed a commit to adilhusain-s/setup-go that referenced this pull request Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants