Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update @zeit/ncc to @vercel/ncc #183

Closed
wants to merge 2 commits into from
Closed

Update @zeit/ncc to @vercel/ncc #183

wants to merge 2 commits into from

Conversation

nikeee
Copy link

@nikeee nikeee commented Jan 20, 2022

Description:
Updates some dependencies. Also, @zeit/ncc is no longer maintained and moved to @vercel/ncc.

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

@nikeee nikeee requested a review from a team January 20, 2022 11:32
@vsafonkin
Copy link

Hi @nikeee, sorry for the delay, could you please update your PR from main and resolve conflicts?

@zeit/ncc is no longer maintained:
```
npm WARN deprecated @zeit/ncc@0.21.1: @zeit/ncc is no longer maintained. Please use @vercel/ncc instead.
```
@nikeee
Copy link
Author

nikeee commented Apr 4, 2022

@vsafonkin done

"semver": "^6.1.1"
},
"devDependencies": {
"@types/jest": "^27.0.2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nikeee looks like the line endings on this file changed to CRLF. Can you change it back to LF?

@vsafonkin we probably should add * text=auto to https://github.com/actions/setup-go/blob/main/.gitattributes

@brcrista
Copy link
Contributor

brcrista commented Apr 4, 2022

@nikeee the check-dist run is failing -- the dist code (which is what actually runs) needs to be updated since package versions changed.

You can just download the artifact from that run and check it in: https://github.com/actions/setup-go/runs/5814071208

@dmitry-shibanov
Copy link
Contributor

Hello @nikeee. I'm going to close your pull request in favour of this one. #229

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants