Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not export GOROOT for Go versions >= 1.9 #175

Merged
merged 6 commits into from Mar 17, 2022
Merged

Do not export GOROOT for Go versions >= 1.9 #175

merged 6 commits into from Mar 17, 2022

Commits on Mar 9, 2022

  1. Add test for export of GOROOT to env var 

    Signed-off-by: Manuel Mendez <mmendez534@gmail.com>
    @mmlb
    mmlb committed Mar 9, 2022
    Copy the full SHA
    ec07be5 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2022

  1. Do not export GOROOT 

    This has not been necessary since [Go 1.9](https://go.dev/doc/go1.9#goroot) at
least (although clunky to do so then) but definitely not since
[Go 1.10](https://go.dev/doc/go1.10#goroot).

This is cargo culting code that is more than 2 years out of date and runs into
issues when multiple go versions are used in an action run.

Signed-off-by: Manuel Mendez <mmendez534@gmail.com>
    @mmlb
    mmlb committed Mar 11, 2022
    Copy the full SHA
    83124a1 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2022

  1. Export GOROOT for versions < 1.9

    @joshmgross
    joshmgross committed Mar 14, 2022
    Copy the full SHA
    2a34c33 View commit details
    Browse the repository at this point in the history

  2. Fix formatting

    @joshmgross
    joshmgross committed Mar 14, 2022
    Copy the full SHA
    802876f View commit details
    Browse the repository at this point in the history

  3. Update dist

    @joshmgross
    joshmgross committed Mar 14, 2022
    Copy the full SHA
    229eefa View commit details
    Browse the repository at this point in the history

  4. Remove duplicated spyOn

    @joshmgross
    joshmgross committed Mar 14, 2022
    Copy the full SHA
    0c03929 View commit details
    Browse the repository at this point in the history