Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(workflow): add cache to workflows using actions/setup-node #120

Closed
wants to merge 1 commit into from
Closed

ci(workflow): add cache to workflows using actions/setup-node #120

wants to merge 1 commit into from

Conversation

oscard0m
Copy link
Contributor

@oscard0m oscard0m commented Jul 5, 2021

Description

Add cache to workflows using actions/setup-node

Context

setup-node GitHub Action just released a new option to add cache to steps using it.

You can find the details here: https://github.blog/changelog/2021-07-02-github-actions-setup-node-now-supports-dependency-caching/


🤖 This PR has been generated automatically by this octoherd script, feel free to run it in your GitHub user/org repositories! 💪🏾

@oscard0m oscard0m requested a review from a team July 5, 2021 00:41
@MagpieMaggie
This comment has been minimized.
@brcrista brcrista closed this Dec 16, 2021
@oscard0m
Copy link
Contributor Author

oscard0m commented Dec 19, 2021

Hi @brcrista ! Could I get more info on why this PR has been closed?

Thanks

@brcrista
Copy link
Contributor

@oscard0m Sorry, to be honest I mistook this for a spam PR. (We get a lot of those.) I see now that the relevant change is

     - name: Setup node 12
        uses: actions/setup-node@v2
        with:
          node-version: 12
          cache: npm

I can't reopen this PR because it looks like your fork no longer exists, but if you can recreate the PR without the extra formatting changes we can give it a look.

It would also be helpful if you could show us what kind of speedup we observe from caching.

@oscard0m
Copy link
Contributor Author

I had to recreate it in #179

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants