Skip to content

Commit

Permalink
Canonicalize versions with makeSemver in getInfoFromDist
Browse files Browse the repository at this point in the history
While getInfoFromManifest stores semver versions in IGoVersionInfo
struct, getInfoFromDist uses "goX.Y.Z" versions with "go" prefix. To
make it consistent between two, convert versions from golang.org/dl
version registry to semver versions.
  • Loading branch information
bdd committed Dec 16, 2020
1 parent 47f75dd commit 38f5ff1
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion dist/index.js
Expand Up @@ -5175,7 +5175,7 @@ function getInfoFromDist(versionSpec, stable) {
return {
type: 'dist',
downloadUrl: downloadUrl,
resolvedVersion: version.version,
resolvedVersion: makeSemver(version.version),
fileName: version.files[0].filename
};
});
Expand Down
2 changes: 1 addition & 1 deletion src/installer.ts
Expand Up @@ -219,7 +219,7 @@ async function getInfoFromDist(
return <IGoVersionInfo>{
type: 'dist',
downloadUrl: downloadUrl,
resolvedVersion: version.version,
resolvedVersion: makeSemver(version.version),
fileName: version.files[0].filename
};
}
Expand Down

0 comments on commit 38f5ff1

Please sign in to comment.