Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update action to node20 #482

Closed
wants to merge 3 commits into from
Closed

Conversation

takost
Copy link

@takost takost commented Nov 16, 2023

Description:
Node 16 has reached end-of-life on 11 Sep 202.
This PR updates the default runtime to node20, rather then node16.

This is supported on all Actions Runners v2.308.0 or later.

Related issue:
Add link to the related issue.

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

@takost takost requested a review from a team as a code owner November 16, 2023 15:30
@dlemstra
Copy link

You might also want to update node_modules/@types/node and maybe also some of the other packages? That can fix this critical in one of the dependencies:

@babel/traverse <7.23.2
Severity: critical
Babel vulnerable to arbitrary code execution when compiling specifically crafted malicious code - GHSA-67hx-6x53-jw92
fix available via npm audit fix
node_modules/@babel/traverse

@takost
Copy link
Author

takost commented Nov 29, 2023

@dlemstra Thanks for your comment, I'll try to update packages.
But could you please help me with the failing test? Looks like test from the externals is out-dated, and I'm not familiar with the process of update of this script.

@dlemstra
Copy link

It looks like someone else created a PR that addresses this issue here: #484?

@takost
Copy link
Author

takost commented Nov 30, 2023

@dlemstra I will close my PR in favour of #484

@takost takost closed this Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants