switch GITHUB_URL to GITHUB_SERVER_URL #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "sha", | ||
| "url", |
There was a problem hiding this comment.
can we safely remove GITHUB_URL?
There was a problem hiding this comment.
what about checkout action?
There was a problem hiding this comment.
or anything already using GITHUB_URL
There was a problem hiding this comment.
I added back compat code to the checkout pr (fallback order: $GITHUB_SERVER_URL || $GITHUB_URL || 'https://github.com'
GHES Alpha is pinned to the 2.169.0 runner, but uses checkout from dotcom. So only checkout needs to hold compat (can delete after alpha support is over)
Nothing else uses GITHUB_URL
There was a problem hiding this comment.
Feature flag only made it out to Ring 1
TingluoHuang
approved these changes
May 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.