set CI=true when launch process in actions runner. #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericsciple
approved these changes
Mar 17, 2020
5 tasks
|
Would be good if you announced such changes somehow, ideally directly in GitHub UI. Yesterday this broke our CI. As it turned out, our tests contained code that depended on this variable. It took quite a while until I found out the reason of the failures. See prettier/prettier#7980 |
|
@chrispat for an idea on where could we announce this kind of change. :) |
|
There should have been a changelog entry as this went out. I will look and see if it didn't publish for some reason. I apologize for the inconvenience. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#368