Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Docker versions to the latest releases #9817

Closed
wants to merge 1 commit into from

Conversation

taleh007
Copy link

@taleh007 taleh007 commented May 9, 2024

Description

Improvement
Update Docker tools to the latest versions.
Right now actions using pinned version of compose (since: #9172), it's quite old and miss a lot of features. Also it's not same across different ubuntu and windows versions

Updates:

  • Ubuntu 20/22:
    • docker-ce-cli 24.0.9 -> 26.1.2
    • docker-ce 24.0.9 -> 26.1.2
    • compose 2.23.3 -> latest (2.27.0)
  • Ubuntu 24:
    • docker-ce-cli 26.1.0 -> 26.1.2
    • docker-ce 26.1.0 -> 26.1.2
  • Windows 2019
    • docker-ce-cli 24.0.7 -> 26.1.2
    • compose 2.23.3 -> 2.27.0
  • Windows 2022
    • docker-ce-cli 24.0.7 -> 26.1.2
    • compose 2.23.3 -> 2.27.0

Related issue:

Check list

  • Related issue / work item is attached
  • Tests are written (if applicable)
  • Documentation is updated (if applicable)
  • Changes are tested and related VM images are successfully generated

Copy link

@TigMour TigMour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

12

@taleh007
Copy link
Author

taleh007 commented May 14, 2024

12

What does it mean?

@taleh007 taleh007 requested a review from TigMour May 14, 2024 17:35
@taspeotis
Copy link

Is there any enthusiasm for simply using latest rather than pegging newer versions of Docker each time? As I understand it some older versions of Docker had compatibility issues around the 25.x releases because of major upgrades within moby/buildkit but they have since been resolved.

Copy link

@npm-run-test npm-run-test left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure, that the tests are passing.

@taleh007
Copy link
Author

Is there any enthusiasm for simply using latest rather than pegging newer versions of Docker each time?

It's good practice to pin such important libs to specific version, to reduce chance of breaking changes which may come with the latest release and will break tons of pipelines.

That's my opinion. I didn't see any comments about it in the repo

@erik-bershel
Copy link
Contributor

Hey @taleh007!

Sorry for delay. There were some internal blockers for this PR, although overall it was a great idea. Now is a good time to update Docker components. But I have couple requests and nitpicks before we get started. Please take a look when you find time:

  • Change PR title please, Update Docker versions to the latest releases -> [Ubuntu, Windows] Update Docker components versions - just to be on the same page with our commits.
  • Please, do not use latest for any of those - we've decided to abort this practice months ago by number of reasons.
  • Rebase your branch to the current main state - it will unlock test generation.
  • Please, use 26.1.3 both for the Docker engine and cli and 2.27.1 for Compose - latest releases contain some exciting changes and fixes.

Thank you in advance!

@erik-bershel
Copy link
Contributor

I'm going to close this PR as inactive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants