Add retry plugin and related options #288

luketomlinson · 2022-09-23T15:57:50Z

This PR adds a few new features:

Support for octokit/plugin-retry.js
3 new options
- retries: the number of times to retry a failed request
- retryAfter: a delay after retrying
- doNotRetry: a list of HTTP status codes to NOT retry

These options largely mirror the options from the octokit plugin.

These options are completely opt in and require you to be explicit: retryAfter and doNotRetry will have no effect unless retries is set.

fixes #104

.licenses/npm/@actions/http-client.dep.yml

action.yml

joshmgross

Could you bump the version to 6.2.1 in package.json?

joshmgross · 2022-09-23T21:19:35Z

src/retry-options.ts

+    retries
+  }
+
+  core.info(


Should this be debug?
Users might not want every step to output this information

luketomlinson · 2022-09-26T13:37:41Z

@joshmgross what do you think about 6.3.0 since this is adding a feature, and not just a bug fix?

joshmgross · 2022-09-26T15:22:22Z

@joshmgross what do you think about 6.3.0 since this is adding a feature, and not just a bug fix?

👍 Sounds good to me

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [actions/github-script](https://togithub.com/actions/github-script) | action | minor | `v6.2.0` -> `v6.3.2` | --- ### Release Notes <details> <summary>actions/github-script</summary> ### [`v6.3.2`](https://togithub.com/actions/github-script/releases/tag/v6.3.2) [Compare Source](https://togithub.com/actions/github-script/compare/v6.3.1...v6.3.2) ##### What's Changed - Update [@actions/core](https://togithub.com/actions/core) to 1.10.0 by [@rentziass](https://togithub.com/rentziass) in [actions/github-script#295 ##### New Contributors - [@rentziass](https://togithub.com/rentziass) made their first contribution in [actions/github-script#295 **Full Changelog**: actions/github-script@v6.3.1...v6.3.2 ### [`v6.3.1`](https://togithub.com/actions/github-script/releases/tag/v6.3.1) [Compare Source](https://togithub.com/actions/github-script/compare/v6.3.0...v6.3.1) #### What's Changed - Fix overriding request options from [@actions/github](https://togithub.com/actions/github) by [@luketomlinson](https://togithub.com/luketomlinson) in [actions/github-script#293 **Full Changelog**: actions/github-script@v6.3.0...v6.3.1 ### [`v6.3.0`](https://togithub.com/actions/github-script/releases/tag/v6.3.0) [Compare Source](https://togithub.com/actions/github-script/compare/v6.2.0...v6.3.0) #### What's Changed - Add retry plugin and related options by [@luketomlinson](https://togithub.com/luketomlinson) in [actions/github-script#288, see https://github.com/actions/github-script/tree/v6.3.0#retries for more information. #### New Contributors - [@luketomlinson](https://togithub.com/luketomlinson) made their first contribution in [actions/github-script#288 **Full Changelog**: actions/github-script@v6.2.0...v6.3.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/DeFiCh/metachain).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [actions/github-script](https://togithub.com/actions/github-script) | action | minor | `v6.2.0` -> `v6.3.3` | --- ### Release Notes <details> <summary>actions/github-script</summary> ### [`v6.3.3`](https://togithub.com/actions/github-script/releases/tag/v6.3.3) [Compare Source](https://togithub.com/actions/github-script/compare/v6.3.2...v6.3.3) #### What's Changed - Update `@actions/glob` to 0.3.0 by [@nineinchnick](https://togithub.com/nineinchnick) in [actions/github-script#279 #### New Contributors - [@nineinchnick](https://togithub.com/nineinchnick) made their first contribution in [actions/github-script#279 **Full Changelog**: actions/github-script@v6.3.2...v6.3.3 ### [`v6.3.2`](https://togithub.com/actions/github-script/releases/tag/v6.3.2) [Compare Source](https://togithub.com/actions/github-script/compare/v6.3.1...v6.3.2) #### What's Changed - Update [@actions/core](https://togithub.com/actions/core) to 1.10.0 by [@rentziass](https://togithub.com/rentziass) in [actions/github-script#295 #### New Contributors - [@rentziass](https://togithub.com/rentziass) made their first contribution in [actions/github-script#295 **Full Changelog**: actions/github-script@v6.3.1...v6.3.2 ### [`v6.3.1`](https://togithub.com/actions/github-script/releases/tag/v6.3.1) [Compare Source](https://togithub.com/actions/github-script/compare/v6.3.0...v6.3.1) #### What's Changed - Fix overriding request options from [@actions/github](https://togithub.com/actions/github) by [@luketomlinson](https://togithub.com/luketomlinson) in [actions/github-script#293 **Full Changelog**: actions/github-script@v6.3.0...v6.3.1 ### [`v6.3.0`](https://togithub.com/actions/github-script/releases/tag/v6.3.0) [Compare Source](https://togithub.com/actions/github-script/compare/v6.2.0...v6.3.0) #### What's Changed - Add retry plugin and related options by [@luketomlinson](https://togithub.com/luketomlinson) in [actions/github-script#288, see https://github.com/actions/github-script/tree/v6.3.0#retries for more information. #### New Contributors - [@luketomlinson](https://togithub.com/luketomlinson) made their first contribution in [actions/github-script#288 **Full Changelog**: actions/github-script@v6.2.0...v6.3.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/BirthdayResearch/sticky).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

luketomlinson added 3 commits September 23, 2022 10:56

Add retry plugin

355d895

refactor and add tests for retry options

660d907

Add more info to action.yml

977060a

luketomlinson requested a review from a team as a code owner September 23, 2022 15:57

Update licenses

55053af

hashtagchris reviewed Sep 23, 2022

View reviewed changes

.licenses/npm/@actions/http-client.dep.yml Outdated Show resolved Hide resolved

Fix http-client license

3cca041

joshmgross reviewed Sep 23, 2022

View reviewed changes

action.yml Outdated Show resolved Hide resolved

action.yml Outdated Show resolved Hide resolved

action.yml Outdated Show resolved Hide resolved

action.yml Outdated Show resolved Hide resolved

luketomlinson added 4 commits September 23, 2022 16:16

PR feedback

3faaff9

update action.yml

e7dbaf0

cleanup quotes

6b09a22

Whitespace

eb0f407

joshmgross approved these changes Sep 23, 2022

View reviewed changes

luketomlinson added 2 commits September 26, 2022 11:23

Core.debug

ac0c7cb

6.3.0

d742690

joshmgross approved these changes Sep 26, 2022

View reviewed changes

joshmgross merged commit d4560e1 into actions:main Sep 26, 2022

luketomlinson mentioned this pull request Sep 30, 2022

Fix overriding request options from @actions/github #293

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add retry plugin and related options #288

Add retry plugin and related options #288

luketomlinson commented Sep 23, 2022 •

edited

joshmgross left a comment

joshmgross Sep 23, 2022

luketomlinson commented Sep 26, 2022

joshmgross commented Sep 26, 2022

Add retry plugin and related options #288

Add retry plugin and related options #288

Conversation

luketomlinson commented Sep 23, 2022 • edited

joshmgross left a comment

Choose a reason for hiding this comment

joshmgross Sep 23, 2022

Choose a reason for hiding this comment

luketomlinson commented Sep 26, 2022

joshmgross commented Sep 26, 2022

luketomlinson commented Sep 23, 2022 •

edited