Update dependencies 2021-06-26 #156
Conversation
This changes the definition of the github object! The endpoints are now accessed via github.rest.{endpoint} rather than `github.{endpoint}`.
Removes Node.js 11 and 13 support
* @typescript-eslint/eslint-plugin to v4.28.0 * @typescript-eslint/parser to v4.28.0 * @vercel/ncc to v0.28.6 * eslint to v7.29.0 * eslint-config-prettier to v8.3.0 * husky to v4.3.8 * prettier to v2.3.2 * typescript to v4.3.4
Thanks! Since javascript actions are run on Node 12 LTS, we should be using that in the workflow rather than 13. |
|
I updated the workflows in #159 to resolve that issue with Jest. It looks like the Licensed check is failing, let me know if you need help updating that. https://github.com/actions/github-script/pull/156/checks?check_run_id=2935017298 |
|
@joshmgross The licenses should be sorted out. I noticed that the pre-commit hook runs under Linux, but I believe it didn't under Windows. Maybe a reason to upgrade husky after all, but that can be a separate PR and I also need to test this again in a clean Windows environment. |
|
This pull request is stale because it has been open for 60 days with no activity. Remove the "Stale" label or comment on the pull request, or it will be closed in 7 days. |
|
This pull request has been marked as stale and closed due to no activity on it. |
|
Sorry, but is there something I can do to help on this PR to solve issue #155? |
|
The maintainers would only need to merge the PR, then tag and release the changes as v5 (semver-major as it contains breaking changes). |
Update dependencies to latest except husky (v5 moves to a somewhat messy file-based approach, but let me know if you want to upgrade anyway).
Fixes #133 and #155.
Breaking changes:
REST endpoint methods are now exposed under a nested object
restby Octokit. Forgithub-script, this means that endpoints are now accessed viagithub.rest.{endpoint}rather thangithub.{endpoint}. Also see:jest 27 removes support for Node.js 11 and 13 (now only supporting LTS versions and Node.js 15). You may want to up the Node.js version in this workflow:
github-script/.github/workflows/ci.yml
Line 13 in 6723192