Skip to content

Fix dependabot alerts #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 16, 2022
Merged

Fix dependabot alerts #64

merged 3 commits into from
Feb 16, 2022

Conversation

NamrataJha
Copy link
Contributor

@NamrataJha NamrataJha commented Feb 15, 2022

Update following dependencies-

  • @types/jest 24.0.23 -> 27.4.0
  • eslint 5.16.0 -> 8.9.0
  • eslint-plugin-github 2.0.0 -> 4.3.5

Change eslint rules to fix breaking changes.

Fixes dependabot alerts

@NamrataJha NamrataJha requested a review from a team as a code owner February 15, 2022 07:13
@NamrataJha NamrataJha force-pushed the fix-dependabot-alerts branch from 60b92df to d6bf5f6 Compare February 15, 2022 08:25
@@ -50,7 +66,10 @@
"@typescript-eslint/semi": ["error", "never"],
"@typescript-eslint/type-annotation-spacing": "error",
"@typescript-eslint/unbound-method": "error",
"no-console": "off"
"no-console": "off",
"import/no-unresolved": "off",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need these extra rules?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The extra rules were getting applied as we switched from github/es6 to github/recommended. The es6 config is not supported in the latest version and has been merged in recommended.
So have just marked the extra rules off as they were breaking the lint.

@NamrataJha NamrataJha merged commit 5e4787d into main Feb 16, 2022
@NamrataJha NamrataJha deleted the fix-dependabot-alerts branch February 16, 2022 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants