Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: anchors in readme #1417

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

Zarthus
Copy link

@Zarthus Zarthus commented Jul 23, 2023

Fixes the "Checkout multiple repos (private)" anchors in the README

They were previously not doing anything, now when you click on it it directs you to the right location

You can view the rendered view of the README on my fork: https://github.com/Zarthus/checkout/tree/fix/readme-anchors

Fixes the "Checkout multiple repos (private)" anchors in the README
@Zarthus Zarthus requested a review from a team as a code owner July 23, 2023 11:53
@pfeerick
Copy link

pfeerick commented Aug 1, 2023

There's more... 🤭 I just ran into this one...
https://github.com/actions/checkout#checkout-pull-request-head-commit-instead-of-merge-commit

@Zarthus
Copy link
Author

Zarthus commented Aug 1, 2023

Thanks! Makes me wonder if it's an intentional thing to support another tool (i.e. some documentation generation tool)

@pfeerick
Copy link

pfeerick commented Aug 3, 2023

Maybe it's just sanitised to all lower case? 🤷

Copy link

@FlorianCassayre FlorianCassayre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I noticed this too. We should push this fix forward because it can be confusing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants