Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retry possibility #505

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add retry possibility #505

wants to merge 3 commits into from

Conversation

cbobach
Copy link

@cbobach cbobach commented Nov 27, 2023

Thanks for a nice project/action 馃檱

After we have automated the issue creation of some of our cyclic tasks we have seen multiple errors raising from this action contributed to race conditions in the underlying API.

I believe that the errors can be contributed to the fact that we are opening and labeling new issues automatic and thus starting multiple runs of this action at the same time.

The current trigger is:

on:
  issues:
    types:
      - opened
      - transferred
      - labeled

I've tried to rerun more of our failed actions and they do succeed on the rerun. Therefore I'm proposing adding a retry possibility to the action such that the action is more resilient to race conditions like these.

I see that the errors we are seeing have been opened as issues:

I've created the PR with existing actions in mind and made the new input non required and default to 0 such that changes won't affect existing uses of this action in case you approve of this change.

Will add retry-limit to list of inputs and make additional calls to the GraphQL API if it for some reason fails.
@cbobach cbobach requested a review from a team as a code owner November 27, 2023 10:21
@stoutgz stoutgz mentioned this pull request May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant