Remove redis events on connection end

[joksnet]

Fix #803. Makes the connection event listeners on and off simetrical.

[evantahler]

Thank you for the contribution, @joksnet! This looks great.

The new test is failing in CI, likely because we need to wait a bit after await connection.connect(); - try adding a sleep or awaiting a redis command's completion to ensure we are connected and the events wired up

[joksnet]

Oh, I mixed this.listeners which is a connection's EventEmitter property and this.eventListeners that are the ones attached to the redis instance. I think with this change should be working correctly, as only error and end events are on the redis instance on connection and off on disconnections. Also changed the interface to match typescript definitions.

Which in the end seemed to be the problem was that error being attached with connection.on('error') was present in this.listeners, the loop in the disconnect was removing it but was not removing the end event.

[evantahler]

Released! https://github.com/actionhero/node-resque/releases/tag/v9.2.1