Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type definitions for acorn.mjs #954

Merged
merged 4 commits into from May 29, 2020
Merged

Add type definitions for acorn.mjs #954

merged 4 commits into from May 29, 2020

Commits on May 27, 2020

  1. Add type definitions for acorn.mjs 

    For TypeScript projects that use the acorn.mjs distribution bundle,
a separate `.mjs.d.ts` needs to be added to the folder. This was
suggested in microsoft/TypeScript#27957 (comment)

In DevTools, we use this in https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2218015
to make it compile with TypeScript
    @TimvdLippe
    TimvdLippe committed May 27, 2020
    Copy the full SHA
    310269d View commit details
    Browse the repository at this point in the history

Commits on May 28, 2020

  1. Fix duplication of types

    @TimvdLippe
    TimvdLippe committed May 28, 2020
    Copy the full SHA
    e09c938 View commit details
    Browse the repository at this point in the history

Commits on May 29, 2020

  1. Reverse import where .mjs.d.ts imports the .d.ts

    @TimvdLippe
    TimvdLippe committed May 29, 2020
    Copy the full SHA
    3f9f277 View commit details
    Browse the repository at this point in the history

  2. Use import * as 

    This removes the need for an extra tsconfig flag
    @TimvdLippe
    TimvdLippe committed May 29, 2020
    Copy the full SHA
    ef06652 View commit details
    Browse the repository at this point in the history