Properly handle line breaks when looking for directives (#1283)

FIX: Properly recognize \"use strict\" when preceded by a string with an escaped newline.
acornjs · Mar 16, 2024 · 9a5ecbc · 9a5ecbc
1 parent bd0aa5c
commit 9a5ecbc
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/acorn/src/parseutil.js b/acorn/src/parseutil.js
@@ -6,7 +6,7 @@ const pp = Parser.prototype
 
 // ## Parser utilities
 
-const literal = /^(?:'((?:\\.|[^'\\])*?)'|"((?:\\.|[^"\\])*?)")/
+const literal = /^(?:'((?:\\.|[^'\\])*?)'|"((?:\\.|[^"\\])*?)")/s
 pp.strictDirective = function(start) {
   if (this.options.ecmaVersion < 5) return false
   for (;;) {

diff --git a/test/tests-directive.js b/test/tests-directive.js
@@ -2,6 +2,7 @@
 if (typeof exports !== "undefined") {
   var driver = require("./driver.js");
   var test = driver.test;
+  var testFail = driver.testFail;
 }
 
 //------------------------------------------------------------------------
@@ -1384,3 +1385,8 @@ test("(a = () => { \"use strict\"; foo }) => { \"use strict\" }", {
     }
   ]
 }, { ecmaVersion: 6 })
+
+testFail(
+  "function invalid() { \"\\7\\\n\"; \"use strict\"; }",
+  "Octal literal in strict mode (1:22)",
+  { ecmaVersion: 6 })