fix: pin stylelint & co packages to working majors
#263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Oh snap, I was working on getting specs passing in https://github.com/ackama/rails-template/pull/262/files and fixed this by installing postcss which apparently is required now - I inferred this from stylelint-scss/stylelint-config-standard-scss#5 |
|
That doesn't surprise me - there's a few peer dependencies we should actually be specifying but haven't (e.g. |
|
I'm going to close this in favour of #262 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stylelint& co are currently failing when using the latest versions for reasons I'm not entirely sure but have seen on projects likeeslint&@typescript-eslintwhen mixing majors - I've not got the time to dig into this, and we'll be using the latest versions possible of all packages anyway so a fix wouldn't be a quick one since it'd need to go through at least one release cycle of a package (and could be multiple packages).This pins us to versions we know work, to unblock CI for other PRs.