Security updates #314
Merged
Security updates #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
G-Rath
force-pushed
the
security-updates
branch
2 times, most recently
from
6ed9d63
to
87361a8
Compare
|
I've removed the yarn integrity check as it's failing CI while being plain wrong. I've regenerated the lock three different times in three different ways, and still cannot make I've verified that the packages whose versions it claims are wrong are in fact the right versions, again pointing towards This was verified on both my local & with @trevh-ack (shout out thank-you for the pairing).
|
G-Rath
force-pushed
the
security-updates
branch
2 times, most recently
from
ff28e91
to
16a5dee
Compare
Merged
joshmcarthur
approved these changes
Jun 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the majority of security vulnerabilities; there are two outstanding for
lighthouse, which are unlikely to be patched in the 5.x.x branch, but for now this is the best we can do so will have to circle back to make a decision on what to do about that later.