Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
is_subnet_of
was broken if the supernet was not the network address.IpNetwork
..ip()
.Adds:
If there is no plans on breaking backwards compatibility, the
ip()
method should be re-introduced in my changes. Also, ifip
is not kept, there would be no need fornetwork()
to compute the network address anymore as the arithmetic can be done in the constructor and the resulting ip stored in the struct, discarding the originalIpAddr
.