is_subnet_of fix

was broken if the supernet was not the network address. Signed-off-by: Fredrick Brennan <copypaste@kittens.ph>
achanda · Jun 13, 2023 · 50640b6 · 50640b6
1 parent ca2da8a
commit 50640b6
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/ipv4.rs b/src/ipv4.rs
@@ -80,7 +80,7 @@ impl Ipv4Network {
 
     /// Checks if the given `Ipv4Network` is a subnet of the other.
     pub fn is_subnet_of(self, other: Ipv4Network) -> bool {
-        other.ip() <= self.ip() && other.broadcast() >= self.broadcast()
+        other.network() <= self.network() && other.broadcast() >= self.broadcast()
     }
 
     /// Checks if the given `Ipv4Network` is a supernet of the other.

diff --git a/src/ipv6.rs b/src/ipv6.rs
@@ -122,7 +122,7 @@ impl Ipv6Network {
 
     /// Checks if the given `Ipv6Network` is a subnet of the other.
     pub fn is_subnet_of(self, other: Ipv6Network) -> bool {
-        other.ip() <= self.ip() && other.broadcast() >= self.broadcast()
+        other.network() <= self.network() && other.broadcast() >= self.broadcast()
     }
 
     /// Checks if the given `Ipv6Network` is a supernet of the other.