Skip to content
This repository has been archived by the owner on Sep 10, 2022. It is now read-only.

Remove fbjs dependency #744

Merged
merged 1 commit into from
Oct 1, 2018
Merged

Remove fbjs dependency #744

merged 1 commit into from
Oct 1, 2018

Conversation

shysteph
Copy link
Contributor

@shysteph shysteph commented Oct 1, 2018

Remove shallowEquals import from fbjs and just copy the function #here
Fix #742 using solution from @gaearon (copy/paste)

@istarkov
Copy link
Contributor

istarkov commented Oct 1, 2018

plz run build https://github.com/acdlite/recompose/blob/master/package.json#L12 and add size-snapshot into the pr

Fix acdlite#742 using solution from @gaearon (copy/paste)
@shysteph
Copy link
Contributor Author

shysteph commented Oct 1, 2018

I had to update yarn.lock as well. I have node 10 installed and upath 1.0.4 is incompatible. I committed them as well because they are involved in the size snapshot.

@istarkov
Copy link
Contributor

istarkov commented Oct 1, 2018

Thank you!

@istarkov istarkov merged commit 68c560b into acdlite:master Oct 1, 2018
@oliviertassinari
Copy link
Contributor

Awesome!

@istarkov
Copy link
Contributor

istarkov commented Oct 1, 2018

@oliviertassinari having that pure was commited into react codebase facebook/react#13748 it is the latest days of recompose in material-ui ;-)

@oliviertassinari
Copy link
Contributor

oliviertassinari commented Oct 1, 2018

Oh could Andrew do that to it's own project! We are still using recompose/wrapDisplayName, and it will takes time before this new pure component is broadly available. We have recently inlined recompose/getDisplayName for an IE11 compatibility use case.

@istarkov
Copy link
Contributor

istarkov commented Oct 1, 2018

Time goes fast :-) because of flow issues I didnt use recompose in my own projects more than 6 monthes. (relay also played a role as I almost dont need any data conversions)

@oliviertassinari
Copy link
Contributor

oliviertassinari commented Oct 1, 2018

@istarkov recompose is damn useful. Both for authoring HOCs and for consuming them. I love the new to render props helper.

@MrLoh
Copy link

MrLoh commented Oct 6, 2018

Will there be a new release soon, I am currently getting an error "export 'default' (imported as 'shallowEqual') was not found in 'fbjs/lib/shallowEqual'.

If I manually patch this commit in my node_modules, everything works fine again. But that's obviously not a long term solution

@oliviertassinari
Copy link
Contributor

@MrLoh Who is importing fbjs?

@MrLoh
Copy link

MrLoh commented Oct 6, 2018

I have no idea why this error occurs, but it comes from inside recompose (node_modules/recompose/dist/Recompose.esm.js 90:14-26 to be exact). What matters however is that this also fixes the issue, but hasn't been released yet, so it cannot be used.

@stof
Copy link

stof commented Oct 22, 2019

@istarkov any ETA for a release including that change ?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package size concern over fbjs
5 participants