Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: setup turbomodule #1206

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

feat: setup turbomodule #1206

wants to merge 4 commits into from

Conversation

pradel
Copy link
Member

@pradel pradel commented Dec 14, 2021

Just a test for now

@changeset-bot
Copy link

changeset-bot bot commented Dec 14, 2021

⚠️ No Changeset found

Latest commit: 9aad812

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Dec 14, 2021

Codecov Report

Merging #1206 (9aad812) into master (4f5b38e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1206   +/-   ##
=======================================
  Coverage   95.28%   95.28%           
=======================================
  Files         106      106           
  Lines        2377     2377           
  Branches      473      473           
=======================================
  Hits         2265     2265           
  Misses        107      107           
  Partials        5        5           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f5b38e...9aad812. Read the comment docs.

@darkbasic
Copy link
Member

Unfortunately turbo is not a viable option because they're not multiplatform anymore:
vercel/turbo#5957

Lerna 7 isn't either: lerna/lerna#3676

At the moment we're still using lerna 6 (so I am actually able to use it on ppc64le) but I've already migrated to yarn 4 which bundles a brand new task runner. I'm planning to use it for the most basic tasks like compiling and testing, like I did in mikro-orm: mikro-orm/mikro-orm#4331
Everything else is for CI consumption only so we can stick with lerna for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants