Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose parser writer opts #37

Conversation

s-h-a-d-o-w
Copy link

@s-h-a-d-o-w s-h-a-d-o-w commented Aug 10, 2022

Let's see whether using the same branch as here will just work out of the box. 馃檪


Exposing these will resolve a number of issues where people want to customize something but don't want to create a full preset to replace the default one with.

Functionally, if these overrides aren't set, their value will obviously be undefined, making this change fully backwards compatible.

Two examples about a simple sorting override:
Fixes conventional-changelog#293
Fixes conventional-changelog#869

(I also tweaked pieces of the docs that seemed excessive to me - linking to the same thing and mentioning how customizable everything is multiple times. 馃槄)

BEGIN_COMMIT_OVERRIDE
feat(options): Expose parser and writer options from conventional-commits-parser and conventional-commits-writer
END_COMMIT_OVERRIDE

@s-h-a-d-o-w s-h-a-d-o-w changed the title Feat/expose parser writer opts feat: expose parser writer opts Aug 10, 2022
@codecov-commenter
Copy link

codecov-commenter commented Aug 11, 2022

Codecov Report

Merging #37 (4bed054) into master (7b7ed56) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #37   +/-   ##
=======================================
  Coverage   97.62%   97.62%           
=======================================
  Files          26       26           
  Lines        1178     1178           
=======================================
  Hits         1150     1150           
  Misses         28       28           
Impacted Files Coverage 螖
lib/lifecycles/changelog.js 100.00% <酶> (酶)

馃摚 We鈥檙e building smart automated test selection to slash your CI/CD build times. Learn more

@TimothyJones
Copy link
Member

Thanks for this! Thanks also for improving the documentation as you went - I really appreciate it!

I noticed that the docs still mention standard-version in a couple of places - but it turns out not just in the places that you changed (oops), so I'll fix that in a subsequent commit.

@TimothyJones TimothyJones merged commit 185a461 into absolute-version:master Aug 11, 2022
@TimothyJones
Copy link
Member

Also thanks for the kind words about Pact-JS! It's really nice to know it was helpful <3

@TimothyJones
Copy link
Member

Released in 10.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

how to generate CHANGELOG order by time Chronological Changelog
3 participants