Ensure optional-dependencies use PEP 508 identifiers

abravalheri · Apr 8, 2022 · 61b668f · 61b668f
1 parent 6f47a41
commit 61b668f
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 0 deletions.
diff --git a/src/validate_pyproject/plugins/setuptools.schema.json b/src/validate_pyproject/plugins/setuptools.schema.json
@@ -203,6 +203,8 @@
         "entry-points": {"$ref": "#/definitions/file-directive"},
         "optional-dependencies": {
           "type": "object",
+          "propertyNames": {"format": "pep508-identifier"},
+          "additionalProperties": false,
           "patternProperties": {".+": {"$ref": "#/definitions/file-directive"}}
         },
         "readme": {

diff --git a/tests/invalid-examples/pretend-setuptools/dependencies/invalid-extra-name.errors.txt b/tests/invalid-examples/pretend-setuptools/dependencies/invalid-extra-name.errors.txt
@@ -0,0 +1,3 @@
+`tool.setuptools.dynamic.optional-dependencies` keys must be named by:
+
+    {format: 'pep508-identifier'}
diff --git a/tests/invalid-examples/pretend-setuptools/dependencies/invalid-extra-name.toml b/tests/invalid-examples/pretend-setuptools/dependencies/invalid-extra-name.toml
@@ -0,0 +1,7 @@
+[project]
+name = "myproj"
+version = "42"
+dynamic = ["optional-dependencies"]
+
+[tool.setuptools.dynamic.optional-dependencies."non pep508 compliant"]
+file = "extra.txt"