Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add File class #681

Closed
abraham opened this issue Jul 3, 2018 · 2 comments
Closed

Add File class #681

abraham opened this issue Jul 3, 2018 · 2 comments
Labels
Media
Milestone
v2.0

Comments

@abraham
Copy link
Owner

abraham commented Jul 3, 2018

Add a File class that handles getting file data for media uploads. The File class will handle getting the file data from a variety of sources (disk, URL, base64, etc) and make sure it's in the needed format for upload.
@abraham abraham added the Media label Jul 3, 2018
This was referenced Jul 3, 2018
Closed
Closed
Closed
Closed
@abraham abraham added this to the v2.0 milestone Jul 3, 2018
This was referenced Jul 23, 2018
Closed
Closed
@abraham abraham mentioned this issue Sep 4, 2018
Closed
@abraham abraham mentioned this issue Feb 4, 2019
Closed
@abraham abraham mentioned this issue Mar 22, 2019
Closed
@jeanlucc
Copy link

jeanlucc commented Jun 28, 2019 •
edited

Hi @abraham,

First a great THANK YOU for this lib!!!

I encountered the problem when I used it for file upload but in my case it could have been solved by not performing the is_readable check here:
https://github.com/abraham/twitteroauth/blob/master/src/TwitterOAuth.php#L295-L296

My use case is I use a URL as path and file_get_contents works fine but the is_readable check make it fail before this.

I'm curious, why is this check needed?

Best,

J-L

This was referenced Sep 11, 2019
Closed
Closed
@abraham abraham mentioned this issue Oct 4, 2019
Closed
@abraham abraham mentioned this issue May 10, 2021
Closed
@JackWH JackWH mentioned this issue Nov 9, 2021
Open
jaechow referenced this issue in swegio/twitteroauth Dec 18, 2021
@jaechow
🛠 Re-worked TwitterOAuth.php 🛠
8aa9106 
:octocat:
-To fill a need for conversion of media URLs to base64
(negating the need for storing the media prior to uploading)
-Added public function `shipit` that privately calls to
-Added private function `uploadMediaNotStored`
jaechow referenced this issue in swegio/twitteroauth Dec 18, 2021
@jaechow
🛠 Re-worked TwitterOAuth.php 🛠
a85d944 
:octocat:
-To fill a need for conversion of media URLs to base64
(negating the need for storing the media prior to uploading)
-Added public function `shipit` that privately calls to
-Added private function `uploadMediaNotStored`
@abraham abraham mentioned this issue Mar 22, 2022
Closed
@abraham abraham mentioned this issue Mar 10, 2023
Closed
@abraham
Copy link
Owner Author

abraham commented Jul 24, 2023

TwitterOAuth is in maintenance mode and major improvements are no longer planned. #1188

@abraham abraham closed this as completed Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Media
Projects
None yet
Milestone
v2.0
Development

No branches or pull requests
2 participants
@abraham @jeanlucc