Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically increase timeouts for media uploads #406

Closed
abraham opened this issue Sep 18, 2015 · 3 comments
Closed

Automatically increase timeouts for media uploads #406

abraham opened this issue Sep 18, 2015 · 3 comments

Comments

@abraham
Copy link
Owner

abraham commented Sep 18, 2015

5 seconds is unlikely to be enough, for media requests they should automatically be increased.

@abraham
Copy link
Owner Author

abraham commented Jan 3, 2016

Something like this would probably work. Although it would probably be better to have two media upload values and have request use the timeout specific to the type of request being performed.

public function upload($path, array $parameters = [], $chunked = false)
{
    list($connection, $timeout) = [$this->connectionTimeout, $this->timeout];
    $this->setTimeouts(30, 30);
    if ($chunked) {
        $result = $this->uploadMediaChunked($path, $parameters);
    } else {
        $result = $this->uploadMediaNotChunked($path, $parameters);
    }
    list($this->connectionTimeout, $this->timeout) = [$connection, $timeout];
    return $result
}

@abraham abraham added this to the v1.0 milestone Feb 23, 2017
@abraham abraham modified the milestones: v1.0, v2.0 Jul 2, 2018
@abraham
Copy link
Owner Author

abraham commented Jul 3, 2018

Related #681

@abraham abraham removed this from the v2.0 milestone Jul 3, 2018
@abraham
Copy link
Owner Author

abraham commented Jul 24, 2023

TwitterOAuth is in maintenance mode and major improvements are no longer planned. #1188

@abraham abraham closed this as completed Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant