Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to rubocop 0.51.0 #55

Merged
merged 5 commits into from
Oct 24, 2017
Merged

Upgrade to rubocop 0.51.0 #55

merged 5 commits into from
Oct 24, 2017

Conversation

mpotter
Copy link
Contributor

@mpotter mpotter commented Oct 21, 2017 •
edited

Updates minimum rubocop version from 0.49.1 to 0.51.0.

  • Set rubocop minimum version to 0.51.0
  • Remove deprecated Style/Encoding rules
  • Update to new Style rules that now use Naming prefix
  • Remove unnecessary utf-8 encoding comment
  • Adhere to gemspec alphabetical order rule

Details in the rubocop CHANGELOG.

@mpotter mpotter requested a review from dennmart October 21, 2017 18:40
@mpotter mpotter changed the title Upgrade to Rubocop 0.51.0 Upgrade to rubocop 0.51.0 Oct 21, 2017
@brandonweiss
Copy link

@mpotter FYI, by copy-pasting the changelog you just notified every single person referenced in the changelog.

@mpotter
Copy link
Contributor Author

mpotter commented Oct 22, 2017

@brandonweiss Argh! I just assumed those links were to the diffs. That's unfortunate (great way to spam, though). Apologies.

@brandonweiss
Copy link

@mpotter No worries!

dennmart
dennmart approved these changes Oct 24, 2017
View reviewed changes
Copy link
Contributor

@dennmart dennmart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mpotter Everything looks okay here! 😸

@mpotter mpotter merged commit 16b7966 into master Oct 24, 2017
@mpotter mpotter deleted the rubocop-0.51.0 branch October 24, 2017 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dennmart dennmart dennmart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mpotter @brandonweiss @dennmart