Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: Make library web3/ethers agnostic and require a EIP1193-compilant request function #1

Merged
merged 2 commits into from Jul 14, 2022
Merged

Refactor: Make library web3/ethers agnostic and require a EIP1193-compilant request function #1

merged 2 commits into from Jul 14, 2022

Conversation

mmv08
Copy link
Contributor

@mmv08 mmv08 commented Jul 13, 2022 •
edited

This PR:

  • refactors the library to be web3/ethers agnostic by requiring a provider implementing EIP-1193 interface

Notable changes:

  • It doesn't checksum the returned address anymore. We could implement checksumming, but usually, the libraries for web3 interaction, such as ethers or web3 implement them already so the library consumer could reuse them

Blockers:

@mmv08 mmv08 requested a review from jfschwarz July 13, 2022 15:12
@mmv08 mmv08 force-pushed the feature/library-agnostic-refactor branch from ba13781 to d20cb6f Compare July 13, 2022 15:13
mmv08
mmv08 commented Jul 13, 2022
View reviewed changes
package.json Outdated Show resolved Hide resolved
@mmv08 mmv08 force-pushed the feature/library-agnostic-refactor branch 2 times, most recently from 82be5b0 to 6b812f4 Compare July 13, 2022 15:16
jfschwarz
jfschwarz reviewed Jul 13, 2022
View reviewed changes
Copy link
Contributor

@jfschwarz jfschwarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🚀 Gonna rename the package and repo to evm-proxies.

Let's maybe add a little section to the readme showing how to use the lib with ethers and web3?

README.md Outdated Show resolved Hide resolved
@mmv08 mmv08 force-pushed the feature/library-agnostic-refactor branch from b6871cd to e627bf8 Compare July 14, 2022 08:21
@mmv08
Copy link
Contributor Author

mmv08 commented Jul 14, 2022

@jfschwarz done. web3.js is a little trickier

@mmv08 mmv08 requested a review from jfschwarz July 14, 2022 08:25
@mmv08 mmv08 force-pushed the feature/library-agnostic-refactor branch 3 times, most recently from f101657 to c6aa3b2 Compare July 14, 2022 10:01
@mmv08 mmv08 changed the title Refactor: Make library web3/ethers agnostic and require a EIP1193 provider Refactor: Make library web3/ethers agnostic and require a EIP1193-compilant request function Jul 14, 2022
@mmv08 mmv08 force-pushed the feature/library-agnostic-refactor branch from c6aa3b2 to 6588ee6 Compare July 14, 2022 10:03
@mmv08 mmv08 force-pushed the feature/library-agnostic-refactor branch from 6588ee6 to 34f3220 Compare July 14, 2022 10:10
jfschwarz
jfschwarz reviewed Jul 14, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@mmv08 @jfschwarz
Update README.md
b892ec4 
Co-authored-by: Jan-Felix <jan-felix.schwarz@gnosis.io>
@mmv08 mmv08 force-pushed the feature/library-agnostic-refactor branch from b8e4891 to b892ec4 Compare July 14, 2022 10:26
@mmv08 mmv08 requested a review from jfschwarz July 14, 2022 10:27
@jfschwarz jfschwarz merged commit ca9786e into main Jul 14, 2022
@jfschwarz jfschwarz deleted the feature/library-agnostic-refactor branch July 14, 2022 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfschwarz jfschwarz jfschwarz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mmv08 @jfschwarz