-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add functions to check version opt out from settings #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinlee6378
requested review from
yolocs and
chloechien
and removed request for
a team
January 3, 2024 18:12
yolocs
requested changes
Jan 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit
yolocs
previously approved these changes
Jan 4, 2024
sethvargo
reviewed
Jan 4, 2024
yolocs
previously approved these changes
Jan 5, 2024
yolocs
approved these changes
Jan 5, 2024
Merged
token-minter-prod bot
added a commit
that referenced
this pull request
Mar 22, 2024
## What's Changed * repo setup by @kevinlee6378 in #1 * Init terraform directory with GCS by @kevinlee6378 in #2 * chore: add terraform readability to CODEOWNERS by @verbanicm in #3 * Add load balancer terraform by @kevinlee6378 in #4 * Expose IP address in output by @kevinlee6378 in #5 * ensure backend bucket depends on compute api by @kevinlee6378 in #6 * Add simple method for checking app verison by @kevinlee6378 in #7 * Return errors instead of swallowing by @kevinlee6378 in #11 * Bump golang.org/x/crypto from 0.14.0 to 0.17.0 by @dependabot in #12 * Bump google.golang.org/grpc from 1.57.0 to 1.57.1 by @dependabot in #13 * create opt out settings via environment variables by @kevinlee6378 in #8 * Add functions to check version opt out from settings by @kevinlee6378 in #9 * unify version pkg to match what is used in opt out file by @kevinlee6378 in #10 * Account for opt out in CheckVersion by @kevinlee6378 in #14 * Bump github.com/lestrrat-go/jwx/v2 from 2.0.11 to 2.0.19 by @dependabot in #18 * Update output text to include how to opt out via environment vars by @kevinlee6378 in #15 * Use camel case for json tags, also generify GitHubURL to AppRepoURL by @pdewilde in #22 * Add support for local storage by @pdewilde in #23 * Switch to atomic write operation for storing json by @pdewilde in #24 * Update deps by @sethvargo in #27 * Update README.md by @pdewilde in #28 * Add release process from `abcxyz/abc` by @pdewilde in #29 * Add workflows for releasing using the new method by @pdewilde in #31 * Fix draft-release bootstrapping by @pdewilde in #32 * Switch from null value to removing key in draft-release by @pdewilde in #33 ## New Contributors * @kevinlee6378 made their first contribution in #1 * @verbanicm made their first contribution in #3 * @dependabot made their first contribution in #12 * @pdewilde made their first contribution in #22 * @sethvargo made their first contribution in #27 **Full Changelog**: https://github.com/abcxyz/abc-updater/commits/v0.0.1 Co-authored-by: token-minter-prod[bot] <125072751+token-minter-prod[bot]@users.noreply.github.com>
Merged
pdewilde
added a commit
that referenced
this pull request
Mar 22, 2024
## What's Changed * repo setup by @kevinlee6378 in #1 * Init terraform directory with GCS by @kevinlee6378 in #2 * chore: add terraform readability to CODEOWNERS by @verbanicm in #3 * Add load balancer terraform by @kevinlee6378 in #4 * Expose IP address in output by @kevinlee6378 in #5 * ensure backend bucket depends on compute api by @kevinlee6378 in #6 * Add simple method for checking app verison by @kevinlee6378 in #7 * Return errors instead of swallowing by @kevinlee6378 in #11 * Bump golang.org/x/crypto from 0.14.0 to 0.17.0 by @dependabot in #12 * Bump google.golang.org/grpc from 1.57.0 to 1.57.1 by @dependabot in #13 * create opt out settings via environment variables by @kevinlee6378 in #8 * Add functions to check version opt out from settings by @kevinlee6378 in #9 * unify version pkg to match what is used in opt out file by @kevinlee6378 in #10 * Account for opt out in CheckVersion by @kevinlee6378 in #14 * Bump github.com/lestrrat-go/jwx/v2 from 2.0.11 to 2.0.19 by @dependabot in #18 * Update output text to include how to opt out via environment vars by @kevinlee6378 in #15 * Use camel case for json tags, also generify GitHubURL to AppRepoURL by @pdewilde in #22 * Add support for local storage by @pdewilde in #23 * Switch to atomic write operation for storing json by @pdewilde in #24 * Update deps by @sethvargo in #27 * Update README.md by @pdewilde in #28 * Add release process from `abcxyz/abc` by @pdewilde in #29 * Add workflows for releasing using the new method by @pdewilde in #31 * Fix draft-release bootstrapping by @pdewilde in #32 * Switch from null value to removing key in draft-release by @pdewilde in #33 ## New Contributors * @kevinlee6378 made their first contribution in #1 * @verbanicm made their first contribution in #3 * @dependabot made their first contribution in #12 * @pdewilde made their first contribution in #22 * @sethvargo made their first contribution in #27 **Full Changelog**: https://github.com/abcxyz/abc-updater/commits/v0.0.1
Merged
token-minter-prod bot
added a commit
that referenced
this pull request
Mar 22, 2024
## What's Changed * repo setup by @kevinlee6378 in #1 * Init terraform directory with GCS by @kevinlee6378 in #2 * chore: add terraform readability to CODEOWNERS by @verbanicm in #3 * Add load balancer terraform by @kevinlee6378 in #4 * Expose IP address in output by @kevinlee6378 in #5 * ensure backend bucket depends on compute api by @kevinlee6378 in #6 * Add simple method for checking app verison by @kevinlee6378 in #7 * Return errors instead of swallowing by @kevinlee6378 in #11 * Bump golang.org/x/crypto from 0.14.0 to 0.17.0 by @dependabot in #12 * Bump google.golang.org/grpc from 1.57.0 to 1.57.1 by @dependabot in #13 * create opt out settings via environment variables by @kevinlee6378 in #8 * Add functions to check version opt out from settings by @kevinlee6378 in #9 * unify version pkg to match what is used in opt out file by @kevinlee6378 in #10 * Account for opt out in CheckVersion by @kevinlee6378 in #14 * Bump github.com/lestrrat-go/jwx/v2 from 2.0.11 to 2.0.19 by @dependabot in #18 * Update output text to include how to opt out via environment vars by @kevinlee6378 in #15 * Use camel case for json tags, also generify GitHubURL to AppRepoURL by @pdewilde in #22 * Add support for local storage by @pdewilde in #23 * Switch to atomic write operation for storing json by @pdewilde in #24 * Update deps by @sethvargo in #27 * Update README.md by @pdewilde in #28 * Add release process from `abcxyz/abc` by @pdewilde in #29 * Add workflows for releasing using the new method by @pdewilde in #31 * Fix draft-release bootstrapping by @pdewilde in #32 * Switch from null value to removing key in draft-release by @pdewilde in #33 * Release: v0.0.1 by @token-minter-prod in #34 * Fix by removing build step by @pdewilde in #35 * Release: v0.0.1 by @pdewilde in #36 * Reset to 0.0.0 to retry release by @pdewilde in #37 ## New Contributors * @kevinlee6378 made their first contribution in #1 * @verbanicm made their first contribution in #3 * @dependabot made their first contribution in #12 * @pdewilde made their first contribution in #22 * @sethvargo made their first contribution in #27 * @token-minter-prod made their first contribution in #34 **Full Changelog**: https://github.com/abcxyz/abc-updater/commits/v0.0.1 Co-authored-by: token-minter-prod[bot] <125072751+token-minter-prod[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allVersionUpdatesIgnored - checks if all versions should be ignored
isIgnored - checks if a specific version should be ignored