Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functions to check version opt out from settings #9

Merged
merged 17 commits into from Jan 5, 2024

Conversation

kevinlee6378
Copy link
Contributor

allVersionUpdatesIgnored - checks if all versions should be ignored
isIgnored - checks if a specific version should be ignored

@kevinlee6378 kevinlee6378 marked this pull request as ready for review January 3, 2024 18:12
@kevinlee6378 kevinlee6378 requested review from a team as code owners January 3, 2024 18:12
@kevinlee6378 kevinlee6378 requested review from yolocs and chloechien and removed request for a team January 3, 2024 18:12
Copy link

@yolocs yolocs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit

sdk/go/abc-updater/opt_out_test.go Outdated Show resolved Hide resolved
yolocs
yolocs previously approved these changes Jan 4, 2024
sdk/go/abc-updater/opt_out.go Outdated Show resolved Hide resolved
sdk/go/abc-updater/opt_out.go Show resolved Hide resolved
sdk/go/abc-updater/opt_out.go Outdated Show resolved Hide resolved
Base automatically changed from kkevinlee/opt-out-load to main January 5, 2024 18:10
@kevinlee6378 kevinlee6378 dismissed yolocs’s stale review January 5, 2024 18:10

The base branch was changed.

yolocs
yolocs previously approved these changes Jan 5, 2024
sdk/go/abc-updater/opt_out_test.go Outdated Show resolved Hide resolved
@kevinlee6378 kevinlee6378 merged commit 8a1e6cc into main Jan 5, 2024
1 check passed
@kevinlee6378 kevinlee6378 deleted the kkevinlee/versions-opt-out branch January 5, 2024 21:40
@token-minter-prod token-minter-prod bot mentioned this pull request Mar 22, 2024
token-minter-prod bot added a commit that referenced this pull request Mar 22, 2024
## What's Changed
* repo setup by @kevinlee6378 in
#1
* Init terraform directory with GCS by @kevinlee6378 in
#2
* chore: add terraform readability to CODEOWNERS by @verbanicm in
#3
* Add load balancer terraform by @kevinlee6378 in
#4
* Expose IP address in output by @kevinlee6378 in
#5
* ensure backend bucket depends on compute api by @kevinlee6378 in
#6
* Add simple method for checking app verison by @kevinlee6378 in
#7
* Return errors instead of swallowing by @kevinlee6378 in
#11
* Bump golang.org/x/crypto from 0.14.0 to 0.17.0 by @dependabot in
#12
* Bump google.golang.org/grpc from 1.57.0 to 1.57.1 by @dependabot in
#13
* create opt out settings via environment variables by @kevinlee6378 in
#8
* Add functions to check version opt out from settings by @kevinlee6378
in #9
* unify version pkg to match what is used in opt out file by
@kevinlee6378 in #10
* Account for opt out in CheckVersion by @kevinlee6378 in
#14
* Bump github.com/lestrrat-go/jwx/v2 from 2.0.11 to 2.0.19 by
@dependabot in #18
* Update output text to include how to opt out via environment vars by
@kevinlee6378 in #15
* Use camel case for json tags, also generify GitHubURL to AppRepoURL by
@pdewilde in #22
* Add support for local storage by @pdewilde in
#23
* Switch to atomic write operation for storing json by @pdewilde in
#24
* Update deps by @sethvargo in
#27
* Update README.md by @pdewilde in
#28
* Add release process from `abcxyz/abc` by @pdewilde in
#29
* Add workflows for releasing using the new method by @pdewilde in
#31
* Fix draft-release bootstrapping by @pdewilde in
#32
* Switch from null value to removing key in draft-release by @pdewilde
in #33

## New Contributors
* @kevinlee6378 made their first contribution in
#1
* @verbanicm made their first contribution in
#3
* @dependabot made their first contribution in
#12
* @pdewilde made their first contribution in
#22
* @sethvargo made their first contribution in
#27

**Full Changelog**: https://github.com/abcxyz/abc-updater/commits/v0.0.1

Co-authored-by: token-minter-prod[bot] <125072751+token-minter-prod[bot]@users.noreply.github.com>
@pdewilde pdewilde mentioned this pull request Mar 22, 2024
pdewilde added a commit that referenced this pull request Mar 22, 2024
## What's Changed
* repo setup by @kevinlee6378 in
#1
* Init terraform directory with GCS by @kevinlee6378 in
#2
* chore: add terraform readability to CODEOWNERS by @verbanicm in
#3
* Add load balancer terraform by @kevinlee6378 in
#4
* Expose IP address in output by @kevinlee6378 in
#5
* ensure backend bucket depends on compute api by @kevinlee6378 in
#6
* Add simple method for checking app verison by @kevinlee6378 in
#7
* Return errors instead of swallowing by @kevinlee6378 in
#11
* Bump golang.org/x/crypto from 0.14.0 to 0.17.0 by @dependabot in
#12
* Bump google.golang.org/grpc from 1.57.0 to 1.57.1 by @dependabot in
#13
* create opt out settings via environment variables by @kevinlee6378 in
#8
* Add functions to check version opt out from settings by @kevinlee6378
in #9
* unify version pkg to match what is used in opt out file by
@kevinlee6378 in #10
* Account for opt out in CheckVersion by @kevinlee6378 in
#14
* Bump github.com/lestrrat-go/jwx/v2 from 2.0.11 to 2.0.19 by
@dependabot in #18
* Update output text to include how to opt out via environment vars by
@kevinlee6378 in #15
* Use camel case for json tags, also generify GitHubURL to AppRepoURL by
@pdewilde in #22
* Add support for local storage by @pdewilde in
#23
* Switch to atomic write operation for storing json by @pdewilde in
#24
* Update deps by @sethvargo in
#27
* Update README.md by @pdewilde in
#28
* Add release process from `abcxyz/abc` by @pdewilde in
#29
* Add workflows for releasing using the new method by @pdewilde in
#31
* Fix draft-release bootstrapping by @pdewilde in
#32
* Switch from null value to removing key in draft-release by @pdewilde
in #33

## New Contributors
* @kevinlee6378 made their first contribution in
#1
* @verbanicm made their first contribution in
#3
* @dependabot made their first contribution in
#12
* @pdewilde made their first contribution in
#22
* @sethvargo made their first contribution in
#27

**Full Changelog**: https://github.com/abcxyz/abc-updater/commits/v0.0.1
@token-minter-prod token-minter-prod bot mentioned this pull request Mar 22, 2024
token-minter-prod bot added a commit that referenced this pull request Mar 22, 2024
## What's Changed
* repo setup by @kevinlee6378 in
#1
* Init terraform directory with GCS by @kevinlee6378 in
#2
* chore: add terraform readability to CODEOWNERS by @verbanicm in
#3
* Add load balancer terraform by @kevinlee6378 in
#4
* Expose IP address in output by @kevinlee6378 in
#5
* ensure backend bucket depends on compute api by @kevinlee6378 in
#6
* Add simple method for checking app verison by @kevinlee6378 in
#7
* Return errors instead of swallowing by @kevinlee6378 in
#11
* Bump golang.org/x/crypto from 0.14.0 to 0.17.0 by @dependabot in
#12
* Bump google.golang.org/grpc from 1.57.0 to 1.57.1 by @dependabot in
#13
* create opt out settings via environment variables by @kevinlee6378 in
#8
* Add functions to check version opt out from settings by @kevinlee6378
in #9
* unify version pkg to match what is used in opt out file by
@kevinlee6378 in #10
* Account for opt out in CheckVersion by @kevinlee6378 in
#14
* Bump github.com/lestrrat-go/jwx/v2 from 2.0.11 to 2.0.19 by
@dependabot in #18
* Update output text to include how to opt out via environment vars by
@kevinlee6378 in #15
* Use camel case for json tags, also generify GitHubURL to AppRepoURL by
@pdewilde in #22
* Add support for local storage by @pdewilde in
#23
* Switch to atomic write operation for storing json by @pdewilde in
#24
* Update deps by @sethvargo in
#27
* Update README.md by @pdewilde in
#28
* Add release process from `abcxyz/abc` by @pdewilde in
#29
* Add workflows for releasing using the new method by @pdewilde in
#31
* Fix draft-release bootstrapping by @pdewilde in
#32
* Switch from null value to removing key in draft-release by @pdewilde
in #33
* Release: v0.0.1 by @token-minter-prod in
#34
* Fix by removing build step by @pdewilde in
#35
* Release: v0.0.1 by @pdewilde in
#36
* Reset to 0.0.0 to retry release by @pdewilde in
#37

## New Contributors
* @kevinlee6378 made their first contribution in
#1
* @verbanicm made their first contribution in
#3
* @dependabot made their first contribution in
#12
* @pdewilde made their first contribution in
#22
* @sethvargo made their first contribution in
#27
* @token-minter-prod made their first contribution in
#34

**Full Changelog**: https://github.com/abcxyz/abc-updater/commits/v0.0.1

Co-authored-by: token-minter-prod[bot] <125072751+token-minter-prod[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants