Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow embed timestamp to be Date in typings #587

Merged
merged 4 commits into from Dec 4, 2019
Merged

Allow embed timestamp to be Date in typings #587

merged 4 commits into from Dec 4, 2019

Commits on Dec 2, 2019

  1. Changed type for EmbedBase.timestamp 

    Type should by `string | Date` in order to allow for doing `timestamp: new Date()`
    @oathompsonjones
    oathompsonjones committed Dec 2, 2019
    Copy the full SHA
    7b16edf View commit details
    Browse the repository at this point in the history

  2. Correction to previous type change. 

    `timestamp`s do not work with `string`s at all, the data type must be `Date`
    @oathompsonjones
    oathompsonjones committed Dec 2, 2019
    Copy the full SHA
    4f32289 View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2019

  1. Changed back to string | Date 

    Stop devs gettings loads of errors if they have already been passing strings not dates
    @oathompsonjones
    oathompsonjones committed Dec 3, 2019
    Copy the full SHA
    1ad6f0e View commit details
    Browse the repository at this point in the history

  2. Swap around Date and string 

    Co-Authored-By: Skillz4Killz <23035000+Skillz4Killz@users.noreply.github.com>
    @oathompsonjones @Skillz4Killz
    oathompsonjones and Skillz4Killz committed Dec 3, 2019
    Copy the full SHA
    8b01402 View commit details
    Browse the repository at this point in the history