Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executeWebhook returns a bare object, not a Message object. #578

Merged
merged 10 commits into from Dec 1, 2019
Merged

executeWebhook returns a bare object, not a Message object. #578

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
0bea517
executeWebhook returns a bare object, not a Message object.
DonovanDMC Nov 28, 2019
00a06e1
revert typings
DonovanDMC Nov 28, 2019
580e3fc
return a Message object on executeWebhook
DonovanDMC Nov 28, 2019
bc96c8c
jsdoc & variable name
DonovanDMC Nov 28, 2019
3209fca
executeWebhook does not return nothing.
DonovanDMC Nov 28, 2019
8f6bdab
executeWebhook returns empty string when wait is false
DonovanDMC Nov 29, 2019
8d7cbf6
typings (same as last)
DonovanDMC Nov 29, 2019
0ad6803
return changes
DonovanDMC Nov 29, 2019
9024e8c
return changes
DonovanDMC Nov 29, 2019
910b648
Fix doc type
abalabahaha Dec 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/Client.js
View file
Open in desktop
Expand Up @@ -628,7 +628,7 @@ class Client extends EventEmitter {
* @arg {Boolean} [options.tts=false] Whether the message should be a TTS message or not
* @arg {Boolean} [options.wait=false] Whether to wait for the server to confirm the message create or not
* @arg {Boolean} [options.disableEveryone] Whether to filter @everyone/@here or not (overrides default)
* @returns {Promise}
* @returns {Promise<Message?>}
*/
executeWebhook(webhookID, token, options) {
if(!options.content && !options.file && !options.embeds) {
Expand All @@ -643,7 +643,7 @@ class Client extends EventEmitter {
username: options.username,
avatar_url: options.avatarURL,
tts: options.tts
}, options.file);
}, options.file).then((response) => options.wait ? new Message(response, this) : undefined);
}

/**
Expand Down