Use Channel.from() in channel event handlers #572
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Khaaz
changed the title
if the channel was created as Channel (Channel.from)
|
Switched that to actually use In CHANNEL_CREATE, with |
abalabahaha
changed the title
|
Implemented alternatively in b0c7a07 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the implementation of
CHANNEL_CREATEandCHANNEL_UPDATEto works with changes in #565 .Since the guild is resolved inside the channel constructor, I first instantiate the Channel and then check for the guild.
This change was tested and it works / actually fix the bug. However please double check that everything is fine.
I am also concerned about the instanceof check toknowif the Guild is valid (cached) or not. Maybe this can be replaced with checking specifically for one of the property always included in
Guild(eg:guild.name)