Adds stream to Permissions.all, and Permissions.allVoice. #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Zoddo
reviewed
Aug 20, 2019
lib/Constants.js
Outdated
| all: 0b1111111111101111111110111111111, | ||
| allGuild: 0b1111100000000000000000010111111, | ||
| all: 0b1111111111101111111111111111111, | ||
| allGuild: 0b1111100000000000000001010111111, |
There was a problem hiding this comment.
I don't think the stream permission should be added in allGuild. It's a voice-channel only permission, it doesn't have any effect guild-wide.
|
Along with the review above, also needs to be updated since #523 was merged first |
|
Sorry for the late update, merged and removed from guild permissions (obviously didn't fit there indeed). |
Khaaz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just realised that #516 added the stream permission without adding it to
Permissions.all,Permissions.allGuildandPermissions.allVoice.This PR addresses that.