Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Channel.from() #565

Merged
merged 19 commits into from Nov 23, 2019
Merged

Channel.from() #565

merged 19 commits into from Nov 23, 2019

Conversation

apacheli
Copy link
Contributor

@apacheli apacheli commented Nov 21, 2019 •
edited

  • Add a new static method to Channel which converts based on .type
  • Clean up Client channel methods and Guild constructor
  • Add a class for store channels

alex-taxiera
alex-taxiera suggested changes Nov 21, 2019
View reviewed changes
Copy link
Contributor

@alex-taxiera alex-taxiera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

someone needs to test this
Annotation 2019-11-20 225632

abalabahaha
abalabahaha requested changes Nov 23, 2019
View reviewed changes
lib/structures/StoreChannel.js Outdated Show resolved Hide resolved
lib/structures/StoreChannel.js Outdated Show resolved Hide resolved
abalabahaha
abalabahaha requested changes Nov 23, 2019
View reviewed changes
lib/structures/TextChannel.js Outdated Show resolved Hide resolved
@abalabahaha abalabahaha self-requested a review November 23, 2019 20:33
@abalabahaha abalabahaha merged commit 236dbf4 into abalabahaha:dev Nov 23, 2019
@Khaaz Khaaz mentioned this pull request Nov 24, 2019
Closed
@Skillz4Killz Skillz4Killz mentioned this pull request Nov 25, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex-taxiera alex-taxiera alex-taxiera requested changes

@abalabahaha abalabahaha abalabahaha approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@apacheli @abalabahaha @alex-taxiera