Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typings typos #560

Merged
merged 8 commits into from Nov 20, 2019
Merged

Conversation

Skillz4Killz
Copy link
Contributor

This PR fixes 2 more typos in the typings.

  1. Overwrite types are member and role.
  2. fields name and value are mandatory and can not be optional.

@DonovanDMC
Copy link
Contributor

Always make PRs into the dev branch

@abalabahaha abalabahaha changed the base branch from master to dev November 18, 2019 10:37
DonovanDMC
DonovanDMC previously approved these changes Nov 18, 2019
lib/structures/GuildChannel.js Outdated Show resolved Hide resolved
abalabahaha
abalabahaha previously approved these changes Nov 20, 2019
GitHub web mergetool sucks
@abalabahaha abalabahaha merged commit 21805a8 into abalabahaha:dev Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants