Skip to content

Commit

Permalink
Fix typings typos (#560)
Browse files Browse the repository at this point in the history
- Some embed field properties are not optional

- Fix `GuildChannel#edit` `options` typings

- Fix `Overwrite#type` typings
  • Loading branch information
Skillz4Killz authored and abalabahaha committed Nov 20, 2019
1 parent c42a766 commit 21805a8
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
5 changes: 3 additions & 2 deletions index.d.ts
Expand Up @@ -372,7 +372,7 @@ declare namespace Eris {
thumbnail?: { url?: string; proxy_url?: string; height?: number; width?: number };
video?: { url: string; height?: number; width?: number };
provider?: { name: string; url?: string };
fields?: { name?: string; value?: string; inline?: boolean }[];
fields?: { name: string; value: string; inline?: boolean }[];
author?: { name: string; url?: string; icon_url?: string; proxy_icon_url?: string };
}
type Embed = {
Expand Down Expand Up @@ -1330,6 +1330,7 @@ declare namespace Eris {
userLimit?: number;
rateLimitPerUser?: number;
nsfw?: boolean;
parentID?: string;
},
reason?: string
): Promise<AnyGuildChannel>;
Expand Down Expand Up @@ -1539,7 +1540,7 @@ declare namespace Eris {

interface Overwrite {
id: string;
type: "user" | "member";
type: "role" | "member";
allow: number;
deny: number;
}
Expand Down
1 change: 1 addition & 0 deletions lib/structures/GuildChannel.js
Expand Up @@ -86,6 +86,7 @@ class GuildChannel extends Channel {
* @arg {Number} [options.bitrate] The bitrate of the channel (guild voice channels only)
* @arg {Number} [options.userLimit] The channel user limit (guild voice channels only)
* @arg {Number} [options.rateLimitPerUser] The time in seconds a user has to wait before sending another message (does not affect bots or users with manageMessages/manageChannel permissions) (guild text channels only)
* @arg {Boolean} [options.nsfw] The nsfw status of the channel
* @arg {Number?} [options.parentID] The ID of the parent channel category for this channel (guild text/voice channels only)
* @arg {String} [reason] The reason to be displayed in audit logs
* @returns {Promise<CategoryChannel | TextChannel | VoiceChannel | NewsChannel>}
Expand Down

0 comments on commit 21805a8

Please sign in to comment.