Restores DIRTY changes information when updating an attribute with ActiveRecordPersistence #824
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I would like AR DIRTY changes information to be cleared after updating a column with the bang method of an event.
In this PR I remove the status key from the DIRTY changes hash.
I also noticed that we were updating the attributes with an
update_all
. Is there any reason for this? I feel thatobj.update_column
is easier (and AR will automatically update the in-memory object).If we don't want to use
update_column
for any reason, we could useupdate_all
, and then callself.clear_attribute_changes([attribute_name])