Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix namespaced scopes #771

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/aasm/persistence/active_record_persistence.rb
Expand Up @@ -40,15 +40,15 @@ def self.included(base)
end

module ClassMethods
def aasm_create_scope(state_machine_name, scope_name)
def aasm_create_scope(state_machine_name, scope_name, state)
if ActiveRecord::VERSION::MAJOR >= 3
conditions = { aasm(state_machine_name).attribute_name => scope_name.to_s }
conditions = { aasm(state_machine_name).attribute_name => state.to_s }
class_eval do
scope scope_name, lambda { where(table_name => conditions) }
end
else
conditions = {
table_name => { aasm(state_machine_name).attribute_name => scope_name.to_s }
table_name => { aasm(state_machine_name).attribute_name => state.to_s }
}
class_eval do
named_scope scope_name, :conditions => conditions
Expand Down
8 changes: 4 additions & 4 deletions lib/aasm/persistence/base.rb
Expand Up @@ -72,17 +72,17 @@ def create_scope?(name)
@state_machine.config.create_scopes && !@klass.respond_to?(name) && @klass.respond_to?(:aasm_create_scope)
end

def create_scope(name)
@klass.aasm_create_scope(@name, name) if create_scope?(name)
def create_scope(name, state)
@klass.aasm_create_scope(@name, name, state) if create_scope?(name)
end

def create_scopes(name)
if namespace?
# Create default scopes even when namespace? for backward compatibility
namepaced_name = "#{namespace}_#{name}"
create_scope(namepaced_name)
create_scope(namepaced_name, name)
end
create_scope(name)
create_scope(name, name)
end
end # Base

Expand Down
4 changes: 2 additions & 2 deletions lib/aasm/persistence/core_data_query_persistence.rb
Expand Up @@ -20,8 +20,8 @@ def self.included(base)
end

module ClassMethods
def aasm_create_scope(state_machine_name, scope_name)
scope(scope_name.to_sym, lambda { where(aasm(state_machine_name).attribute_name.to_sym).eq(scope_name.to_s) })
def aasm_create_scope(state_machine_name, scope_name, state)
scope(scope_name.to_sym, lambda { where(aasm(state_machine_name).attribute_name.to_sym).eq(state.to_s) })
end
end

Expand Down
4 changes: 2 additions & 2 deletions lib/aasm/persistence/mongoid_persistence.rb
Expand Up @@ -39,11 +39,11 @@ def self.included(base)
end

module ClassMethods
def aasm_create_scope(state_machine_name, scope_name)
def aasm_create_scope(state_machine_name, scope_name, state)
scope_options = lambda {
send(
:where,
{ aasm(state_machine_name).attribute_name.to_sym => scope_name.to_s }
{ aasm(state_machine_name).attribute_name.to_sym => state.to_s }
)
}
send(:scope, scope_name, scope_options)
Expand Down
4 changes: 2 additions & 2 deletions lib/aasm/persistence/no_brainer_persistence.rb
Expand Up @@ -39,9 +39,9 @@ def self.included(base)
end

module ClassMethods
def aasm_create_scope(state_machine_name, scope_name)
def aasm_create_scope(state_machine_name, scope_name, state)
scope_options = lambda {
where(aasm(state_machine_name).attribute_name.to_sym => scope_name.to_s)
where(aasm(state_machine_name).attribute_name.to_sym => state.to_s)
}
send(:scope, scope_name, scope_options)
end
Expand Down
Expand Up @@ -338,14 +338,18 @@
expect(MultipleNamespaced).to respond_to(:car_sold)

expect(MultipleNamespaced.car_unsold.is_a?(ActiveRecord::Relation)).to be_truthy
expect(MultipleNamespaced.car_unsold.where_values_hash.stringify_keys).to eq({ "status" => "unsold" })
expect(MultipleNamespaced.car_sold.is_a?(ActiveRecord::Relation)).to be_truthy
expect(MultipleNamespaced.car_sold.where_values_hash.stringify_keys).to eq({ "status" => "sold" })
end
it "add unnamespaced scopes" do
expect(MultipleNamespaced).to respond_to(:unsold)
expect(MultipleNamespaced).to respond_to(:sold)

expect(MultipleNamespaced.unsold.is_a?(ActiveRecord::Relation)).to be_truthy
expect(MultipleNamespaced.unsold.where_values_hash.stringify_keys).to eq({ "status" => "unsold" })
expect(MultipleNamespaced.sold.is_a?(ActiveRecord::Relation)).to be_truthy
expect(MultipleNamespaced.sold.where_values_hash.stringify_keys).to eq({ "status" => "sold" })
end
end
end # scopes
Expand Down