Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: fix statement about whinyness of aasm #764

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fwolfst
Copy link
Contributor

@fwolfst fwolfst commented Dec 6, 2021

At least that is what I understand from the example and it also sounds right"er" (ya, non-native english-speaker here ;) ).

At least that is what I understand from the example and it also sounds right"er" (ya, non-native english-speaker here ;) ).
@codeclimate
Copy link

codeclimate bot commented Dec 6, 2021

Code Climate has analyzed commit 9826abe and detected 0 issues on this pull request.

View more on Code Climate.

@@ -106,7 +106,7 @@ job.run # => raises AASM::InvalidTransition
```

If you don't like exceptions and prefer a simple `true` or `false` as response, tell
AASM not to be *whiny*:
AASM not to not be *whiny*:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be a double negative, which reads the same as telling it to be whiny. It should either be not to (as it is already) or to not: either works in English.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants