Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add github actions config #750

Merged

Conversation

aka47
Copy link
Contributor

@aka47 aka47 commented Aug 20, 2021

As travis stopped be free for all - lets move to github actions. Also add ruby-3.0 and trufflerruby to test matrix

Fixes #749, #717 and #675

As travis stopped be free for all - lets move to github actions.

- Add ruby 3.0 to build matrix
- using DymnaDB ready made action installer did not work - could work with some more time for investigation. But it works the old way.
@aka47 aka47 force-pushed the move-build-from-travis-to-github-actions branch from 2978f8a to 87aa82d Compare August 20, 2021 11:33
@codeclimate
Copy link

codeclimate bot commented Aug 20, 2021

Code Climate has analyzed commit 9fc9d34 and detected 0 issues on this pull request.

View more on Code Climate.

@aka47
Copy link
Contributor Author

aka47 commented Sep 1, 2021

@anilmaurya this is ready to be merged.. can you review it or whom should I ask for this?
The action run is visible here.. https://github.com/aka47/aasm/actions/runs/1150819885

Once merged and configured it will show up under checks on every PR..

@anilmaurya
Copy link
Member

@aka47 Thank you for this PR

I can see that you have removed CI for nobrainer, as we support nobrainer so we should run specs for nobrainer as well.

@aka47
Copy link
Contributor Author

aka47 commented Sep 2, 2021

@aka47 Thank you for this PR

I can see that you have removed CI for nobrainer, as we support nobrainer so we should run specs for nobrainer as well.

For some reason it got deactivated in main 2 years ago .. https://github.com/aasm/aasm/blob/master/.travis.yml

looks like this was the reason..
100082e#diff-6ac3f79fc25d95cd1e3d51da53a4b21b939437392578a35ae8cd6d5366ca5485

It looks better be done in a separate PR once this one is merged.. as it is not directly related to the switch.. , what you think?

@anilmaurya anilmaurya merged commit b94aa96 into aasm:master Sep 2, 2021
@anilmaurya
Copy link
Member

Ohh, it was travis issue back then.

Make sense to fix in separate PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants