Skip to content

Commit

Permalink
Update version in recommendation to add after_commit_everywhere
Browse files Browse the repository at this point in the history
after_commit_everywhere 1.0.0 has been released without any breaking changes.

See https://github.com/Envek/after_commit_everywhere/releases/tag/v1.0.0
  • Loading branch information
Envek authored and Anil Kumar Maurya committed Feb 18, 2021
1 parent ea04160 commit 6786b2e
Show file tree
Hide file tree
Showing 8 changed files with 13 additions and 13 deletions.
10 changes: 5 additions & 5 deletions Appraisals
Expand Up @@ -8,7 +8,7 @@ appraise 'rails_4.2' do
gem 'aws-sdk', '~> 2', platforms: :ruby
gem 'redis-objects'
gem 'activerecord-jdbcsqlite3-adapter', '1.3.24', platforms: :jruby
gem "after_commit_everywhere", "~> 0.1", ">= 0.1.5"
gem "after_commit_everywhere", "~> 1.0"
end

appraise 'rails_4.2_nobrainer' do
Expand All @@ -21,7 +21,7 @@ appraise 'rails_4.2_mongoid_5' do
gem 'rails', '4.2.5'
gem 'mongoid', '~> 5.0'
gem 'activerecord-jdbcsqlite3-adapter', '1.3.24', platforms: :jruby
gem "after_commit_everywhere", "~> 0.1", ">= 0.1.5"
gem "after_commit_everywhere", "~> 1.0"
end

appraise 'rails_5.0' do
Expand All @@ -31,7 +31,7 @@ appraise 'rails_5.0' do
gem 'dynamoid', '~> 1.3', platforms: :ruby
gem 'aws-sdk', '~> 2', platforms: :ruby
gem 'redis-objects'
gem "after_commit_everywhere", "~> 0.1", ">= 0.1.5"
gem "after_commit_everywhere", "~> 1.0"
end

appraise 'rails_5.0_nobrainer' do
Expand All @@ -46,7 +46,7 @@ appraise 'rails_5.1' do
gem 'dynamoid', '~> 1.3', platforms: :ruby
gem 'aws-sdk', '~>2', platforms: :ruby
gem 'redis-objects'
gem "after_commit_everywhere", "~> 0.1", ">= 0.1.5"
gem "after_commit_everywhere", "~> 1.0"
end

appraise 'rails_5.2' do
Expand All @@ -56,7 +56,7 @@ appraise 'rails_5.2' do
gem 'dynamoid', '~>2.2', platforms: :ruby
gem 'aws-sdk', '~>2', platforms: :ruby
gem 'redis-objects'
gem "after_commit_everywhere", "~> 0.1", ">= 0.1.5"
gem "after_commit_everywhere", "~> 1.0"
end

appraise 'norails' do
Expand Down
4 changes: 2 additions & 2 deletions README.md
Expand Up @@ -719,7 +719,7 @@ end
AASM comes with support for ActiveRecord and allows automatic persisting of the object's
state in the database.

Add `gem 'after_commit_everywhere', '~> 0.1', '>= 0.1.5'` to your Gemfile
Add `gem 'after_commit_everywhere', '~> 1.0'` to your Gemfile.

```ruby
class Job < ActiveRecord::Base
Expand Down Expand Up @@ -1028,7 +1028,7 @@ job.save! #notify_about_running_job is not run
Please note that `:after_commit` AASM callbacks behaves around custom implementation
of transaction pattern rather than a real-life DB transaction. This fact still causes
the race conditions and redundant callback calls within nested transaction. In order
to fix that it's highly recommended to add `gem 'after_commit_everywhere', '~> 0.1', '>= 0.1.5'`
to fix that it's highly recommended to add `gem 'after_commit_everywhere', '~> 1.0'`
to your `Gemfile`.

If you want to encapsulate state changes within an own transaction, the behavior
Expand Down
2 changes: 1 addition & 1 deletion gemfiles/rails_4.2.gemfile
Expand Up @@ -12,6 +12,6 @@ gem "dynamoid", "~> 1", platforms: :ruby
gem "aws-sdk", "~> 2", platforms: :ruby
gem "redis-objects"
gem "activerecord-jdbcsqlite3-adapter", "1.3.24", platforms: :jruby
gem "after_commit_everywhere", "~> 0.1", ">= 0.1.5"
gem "after_commit_everywhere", "~> 1.0"

gemspec path: "../"
2 changes: 1 addition & 1 deletion gemfiles/rails_4.2_mongoid_5.gemfile
Expand Up @@ -7,6 +7,6 @@ gem "rails", "4.2.5"
gem "mime-types", "~> 2", platforms: [:ruby_19, :jruby]
gem "mongoid", "~> 5.0"
gem "activerecord-jdbcsqlite3-adapter", "1.3.24", platforms: :jruby
gem "after_commit_everywhere", "~> 0.1", ">= 0.1.5"
gem "after_commit_everywhere", "~> 1.0"

gemspec path: "../"
2 changes: 1 addition & 1 deletion gemfiles/rails_5.0.gemfile
Expand Up @@ -9,6 +9,6 @@ gem "sequel"
gem "dynamoid", "~> 1.3", platforms: :ruby
gem "aws-sdk", "~> 2", platforms: :ruby
gem "redis-objects"
gem "after_commit_everywhere", "~> 0.1", ">= 0.1.5"
gem "after_commit_everywhere", "~> 1.0"

gemspec path: "../"
2 changes: 1 addition & 1 deletion gemfiles/rails_5.1.gemfile
Expand Up @@ -9,6 +9,6 @@ gem "sequel"
gem "dynamoid", "~> 1.3", platforms: :ruby
gem "aws-sdk", "~>2", platforms: :ruby
gem "redis-objects"
gem "after_commit_everywhere", "~> 0.1", ">= 0.1.5"
gem "after_commit_everywhere", "~> 1.0"

gemspec path: "../"
2 changes: 1 addition & 1 deletion gemfiles/rails_5.2.gemfile
Expand Up @@ -9,6 +9,6 @@ gem "sequel"
gem "dynamoid", "~>2.2", platforms: :ruby
gem "aws-sdk", "~>2", platforms: :ruby
gem "redis-objects"
gem "after_commit_everywhere", "~> 0.1", ">= 0.1.5"
gem "after_commit_everywhere", "~> 1.0"

gemspec path: "../"
2 changes: 1 addition & 1 deletion lib/aasm/persistence/active_record_persistence.rb
Expand Up @@ -73,7 +73,7 @@ def aasm_execute_after_commit
rescue LoadError
warn <<-MSG
[DEPRECATION] :after_commit AASM callback is not safe in terms of race conditions and redundant calls.
Please add `gem 'after_commit_everywhere', '~> 0.1', '>= 0.1.5'` to your Gemfile in order to fix that.
Please add `gem 'after_commit_everywhere', '~> 1.0'` to your Gemfile in order to fix that.
MSG
yield
end
Expand Down

0 comments on commit 6786b2e

Please sign in to comment.