Fixed idownloadcoupon scraping

[samin-irtiza]

Description

Fixed idownloadcoupon scraping by redirecting redeem button url manually and parsing the redirected udemy link with the coupon code.

Fixes #432

Type of change

Added a new function in http_utils.py called http_get_no_redirect that doesn't follow redirected url
Modified idownloadcoupon.py file and function called get_udemy_course_link. changed the url parsing code.

• Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

• Running the script in idownloadcoupon only mode by running python.exe run_enroller.py --idownloadcoupon

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• Any dependent changes have been merged and published in downstream modules
• I have added tests that prove my fix is effective or that my feature works (Optional)
• New and existing unit tests pass locally with my changes (Optional)

[samin-irtiza]

Hi,
I haven't used 'black' to format code before. Trying to patch provided by restyled.io fails and produces error similar to this open issue involving Visual studio. That is why I haven't pushed code styling commit to the PR. Otherwise my code is working fine and locally its running smoothly.

[cullzie]

Hey @samin-irtiza
Thanks for the PR.
I think this could be added to the existing http_get method with an argument like redirect=True being the default. In cases where we don't want the redirect we can pass redirect=False

[samin-irtiza]

Hi @cullzie
Thanks for the feedback. I always try not to modify existing code as much as possible in a PR that's why I created the new method.

[cullzie]

Hey @samin-irtiza, The problem at the moment is there are too many diffs showing in this PR meaning its hard to see the actual changes.
I think the only change you made was to add in that method but we could make the change in maybe 2-3 lines if we update the existing method to accept redirect param similar to how it takes headers and then modifying the specific scraper with the issue to pass redirect=false.
If you run black and isort it should resolve the majority of the diffs that are showing here.

[cullzie]

@samin-irtiza Can you please tidy up this PR to only show changes you made. At the moment everything is showing up as changed. Thanks

[samin-irtiza]

Hi @cullzie, I linted the code with black to tidy it up, but that seems to have caused more changes. Not sure what else I can do.

[fakeid30]

আমার কাছে ঠিকই লাগছে, আশা করি কালজি আপনার চেঞ্জ অ্যাক্সেপ্ট করবে। @samin-irtiza

[cullzie]

Ok thanks @samin-irtiza
I will merge since it will get reformatted at another stage if there is an issue.
Thanks for your contribution 🦖