Fix broken tests and compatibility with PHP 8 #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now fixed upstream
aaemnnosttv
changed the title
|
Tests are failing here due to wp-sqlite-db compatibility with PHP 8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests started failing after changes were introduced to wp-cli-tests which broke a temporary workaround that was in place.
See wp-cli/wp-cli-tests#127
This PR also updates the version constraint for
illuminate/containerto support newer versions. It was previously locked to a specific 5.x range due to inclusion ofilluminate/supportin later versions, but this was since removed in laravel/framework#30518 (https://github.com/illuminate/container/releases/tag/v6.5.1).