Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load Android Gradle Plugin conditionally #22

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SaeedZhiany
Copy link

This wraps the Android Gradle plugin dependency in the buildscripts section of android/build.gradle in a conditional:

if (project == rootProject) {
    // ... (dependency here)
}

The Android Gradle plugin is only required when opening the project stand-alone, not when it is included as a dependency. By doing this, the project opens correctly in Android Studio, and it can also be consumed as a native module dependency from an application project without affecting the app project (avoiding unnecessary downloads/conflicts/etc).

for more info, you can refer to this thread and especially this comment.

@SaeedZhiany
Copy link
Author

@aMarCruz

can you please review and merge this?

also, publish a new version on npm if it's possible.

Thanks

vasylnahuliak added a commit to vasylnahuliak/react-native-text-size that referenced this pull request Aug 7, 2023
@vasylnahuliak
Copy link

Feel free to use this fork
https://github.com/vasylnahuliak/react-native-text-size

@SaeedZhiany
Copy link
Author

Feel free to use this fork https://github.com/vasylnahuliak/react-native-text-size

@vasylnahuliak

Are you plan to actively maintain your fork? if yes, @aMarCruz can transfer the ownership of his repository to you (according to the Readme of the repository, in case you missed the section before creating a new fork).

image

@vasylnahuliak
Copy link

vasylnahuliak commented Aug 7, 2023

I do not have any plan for active maintenance. This fork pointed to fixing compatibility with React Native 0.72.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants